Mail archive
alpine-devel

Re: [alpine-devel] [PATCH 8/8] main/syslinux: hooks for bootloader password

From: Dubiousjim <dubiousjim_at_gmail.com>
Date: Fri, 28 Jun 2013 12:40:00 -0400

On Fri, Jun 28, 2013 at 04:54:53PM +0200, Natanael Copa wrote:
> On Thu, 27 Jun 2013 03:32:21 -0400
> Dubiousjim <dubiousjim_at_gmail.com> wrote:

> > diff --git a/main/syslinux/APKBUILD b/main/syslinux/APKBUILD
> > index 79d7e6c..a6c0f54 100644
> > --- a/main/syslinux/APKBUILD
> > +++ b/main/syslinux/APKBUILD
> > _at_@ -39,6 +39,7 @@ build() {
> > package() {
> > cd "$_builddir"
> > make INSTALLROOT="$pkgdir" MANDIR=/usr/share/man local-install
> > + install -D -m755 utils/sha1pass "$pkgdir"/usr/sbin/sha1pass || return 1
>
> I had a look at this script but i don't like it.
> 1) IMHO its useless use of perl. A tiny C app using crypt(3) would do
> the same job with less lines and without perl.
> 2) it requires that password is specified on command line. I think it
> should at least optionally be able to read it from stdin.
>
> Looks like it supports sha256/sha512 passwords. Maybe we could use
> cryptpw instead?
>
> Could you please test if the cryptpw generated passwd works? If so,
> then we don't install sha1pass which does things bad.

Ok, I'll queue that up. I was just taking that script from the syslinux
source folder.

-- 
Dubiousjim
dubiousjim_at_gmail.com
---
Unsubscribe:  alpine-devel+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-devel+help_at_lists.alpinelinux.org
---
Received on Fri Jun 28 2013 - 12:40:00 UTC