Mail archive
alpine-devel

Re: [alpine-devel] [PATCH] /testing/openvswitch - version bump to 2.01 + revised init scripts

From: Natanael Copa <ncopa_at_alpinelinux.org>
Date: Wed, 12 Mar 2014 19:13:48 +0000

I applied it and cleaned up the patch handling a bit and added a patch
for musl building.

I think the below needs be done differently though.

On Wed, 12 Mar 2014 17:36:50 +0000
Stuart Cardall <developer_at_it-offshore.co.uk> wrote:

> db="/etc/openvswitch/conf.db"
> if [ -e "$db" ]; then
> - echo "Trying schema migration for $db..."
> - ovsdb-tool convert "$db" "/usr/share/openvswitch/vswitch.ovsschema"
> + print_red "\nStopping OVS Database\n"; rc-service ovsdb-server stop
> + print_green "\nTrying schema migration for $db..."
> + ovsdb-tool convert "$db" "/usr/share/openvswitch/vswitch.ovsschema"
> + print_green "\nStarting OVS Database\n"; rc-service ovsdb-server start
> else
> - echo "Creating new Open vSwitch database $db..."
> - ovsdb-tool create "$db" "/usr/share/openvswitch/vswitch.ovsschema"
> + print_green "\nCreating new Open vSwitch database $db...\n"
> + ovsdb-tool create "$db" "/usr/share/openvswitch/vswitch.ovsschema"
> fi
>
> +

What will happen if you have a conf.db, but it breaks your networking
so you stop the service. Then you upgrade. The post install/upgrade
will start it even if that was not the intention.

We don't start and stop services from install/upgrade/deinstall scripts.

-nc


---
Unsubscribe:  alpine-devel+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-devel+help_at_lists.alpinelinux.org
---
Received on Wed Mar 12 2014 - 19:13:48 GMT