Mail archive
alpine-devel

Re: [alpine-devel] [PATCH] Add "-s" short option for "--simulate"

From: Natanael Copa <ncopa_at_alpinelinux.org>
Date: Mon, 30 Jun 2014 08:55:56 +0200

On Sat, 28 Jun 2014 19:39:51 -0700
Isaac Dunham <ibid.ag_at_gmail.com> wrote:

> Typing the long option gets old.
> ---
> src/apk.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)

Have you checked that it does not break apk info -s <package>? (for displaying size usage)

-nc

>
> diff --git a/src/apk.c b/src/apk.c
> index 970bbb1..8e3ae7c 100644
> --- a/src/apk.c
> +++ b/src/apk.c
> _at_@ -50,6 +50,8 @@ static struct apk_option generic_options[] = {
> { 'V', "version", "Print program version and exit" },
> { 'f', "force", "Do what was asked even if it looks dangerous" },
> { 'U', "update-cache", "Update the repository cache" },
> + { 's', "simulate", "Show what would be done without actually "
> + "doing it" },
> { 0x101, "progress", "Show a progress bar" },
> { 0x10f, "progress-fd", "Write progress to fd", required_argument, "FD" },
> { 0x110, "no-progress", "Disable progress bar even for TTYs" },
> _at_@ -59,8 +61,6 @@ static struct apk_option generic_options[] = {
> "package removal" },
> { 0x103, "allow-untrusted", "Blindly install packages with untrusted "
> "signatures or no signature at all" },
> - { 0x104, "simulate", "Show what would be done without actually "
> - "doing it" },
> { 0x105, "wait", "Wait for TIME seconds to get an exclusive "
> "repository lock before failing",
> required_argument, "TIME" },
> _at_@ -409,6 +409,9 @@ int main(int argc, char **argv)
> case 'U':
> apk_flags |= APK_UPDATE_CACHE;
> break;
> + case 's':
> + apk_flags |= APK_SIMULATE;
> + break;
> case 0x101:
> apk_flags |= APK_PROGRESS;
> break;
> _at_@ -424,9 +427,6 @@ int main(int argc, char **argv)
> case 0x103:
> apk_flags |= APK_ALLOW_UNTRUSTED;
> break;
> - case 0x104:
> - apk_flags |= APK_SIMULATE;
> - break;
> case 0x106:
> apk_flags |= APK_PURGE;
> break;



---
Unsubscribe:  alpine-devel+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-devel+help_at_lists.alpinelinux.org
---
Received on Mon Jun 30 2014 - 08:55:56 UTC