Mail archive
alpine-devel

Re: [alpine-devel] [PATCH] main/ppp: fix _mv function in APKBUILD

From: Natanael Copa <ncopa_at_alpinelinux.org>
Date: Fri, 5 Dec 2014 14:52:32 +0100

On Wed, 3 Dec 2014 20:12:46 +0200
Valery Kartel <valery.kartel_at_gmail.com> wrote:

> ---
> main/ppp/APKBUILD | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/main/ppp/APKBUILD b/main/ppp/APKBUILD
> index 5302c87..1417be5 100644
> --- a/main/ppp/APKBUILD
> +++ b/main/ppp/APKBUILD
> _at_@ -150,7 +150,9 @@ radius_doc() {
>
> _mv() {
> install -m $2 -D "$pkgdir"/$1 "$subpkgdir"/$1
> - [ -n $3 ] && gzip -9 "$subpkgdir"/$1
> + if [ "$3" = "doc" ]; then
> + gzip -9 "$subpkgdir"/$1
> + fi
> rm "$pkgdir"/$1
> }
> md5sums="78818f40e6d33a1d1de68a1551f6595a ppp-2.4.7.tar.gz

abuild will compress man pages for you. you dont need to do it manually.

We normally ship a common -doc subpackage that includes docs for all subpackages.

So, ppp-chat-doc and ppp-radius-doc should all go into ppp-doc.

It keeps things simpler.

i fixed that.

Thanks!

-nc


---
Unsubscribe:  alpine-devel+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-devel+help_at_lists.alpinelinux.org
---
Received on Fri Dec 05 2014 - 14:52:32 UTC