Mail archive
alpine-devel

Re: [alpine-devel] SpamAssassin DNSBL tests fail after changes in perl (patch included)

From: Johan Dahlberg <johan_at_dnix.se>
Date: Fri, 26 Dec 2014 03:28:09 +0200

On Thu, 25 Dec 2014 at 13:08:32, Leonardo Arena wrote:
> On gio, 2014-12-25 at 13:32 +0200, Johan Dahlberg wrote:
> > On Thu, 25 Dec 2014 at 10:55:08, Leonardo Arena wrote:
> > > On lun, 2014-12-22 at 21:11 +0200, Johan Dahlberg wrote:
> > > > On Mon, 22 Dec 2014 at 19:05:29, Johan Dahlberg wrote:
> > > > > On Mon, 22 Dec 2014 at 17:12:13, Leonardo Arena wrote:
> > > > > > On mer, 2014-12-17 at 11:49 +0200, Johan Dahlberg wrote:
> > > > > > > --- SpamAssassin/DnsResolver.pm.bak
> > > > > > > +++ SpamAssassin/DnsResolver.pm
> > > > > > > _at_@ -204,8 +204,10 @@
> > > > > > > _at_ns_addr_port = @{$self->{conf}->{dns_servers}};
> > > > > > > dbg("dns: servers set by config to: %s", join(',
> > > > > > > ',_at_ns_addr_port));
> > > > > > > } elsif ($res) { # default as provided by Net::DNS, e.g.
> > > > > > > /etc/resolv.conf
> > > > > > > - _at_ns_addr_port = map(untaint_var("[$_]:" . $res->{port}),
> > > > > > > - _at_{$res->{nameservers}});
> > > > > > > + my _at_ns = $res->UNIVERSAL::can('nameservers') ? $res->nameservers
> > > > > > > + :
> > > > > > > _at_{$res->{nameservers}};
> > > > > > > + my $port = $res->UNIVERSAL::can('port') ? $res->port :
> > > > > > > $res->{port};
> > > > > > > + _at_ns_addr_port = map(untaint_var("[$_]:" . $port), @ns);
> > > > > > > dbg("dns: servers obtained from Net::DNS : %s", join(',
> > > > > > > ',_at_ns_addr_port));
> > > > > > > }
> > > > > > > return _at_ns_addr_port;
> > > > > >
> > > > > >
> > > > > > Hi,
> > > > > > thanks for your contribution.
> > > > > > Would it be possible to have a GIT patch? It would be easier and 100%
> > > > > > error-free to apply.
> > > > > > Thanks!
> > > > > >
> > > > > > R,
> > > > > > leo
> > > > >
> > > > > Hello, I'm not so used to working with git, but I think the attached
> > > > > patch is correct.
> > > > >
> > > > > Johan
> > > >
> > > > > diff --git a/lib/Mail/SpamAssassin/DnsResolver.pm.orig b/lib/Mail/SpamAssassin/DnsResolver.pm
> > > > > index 41ae81c..fdc1e5e 100644
> > > > > --- a/lib/Mail/SpamAssassin/DnsResolver.pm.orig
> > > > > +++ b/lib/Mail/SpamAssassin/DnsResolver.pm
> > > > > _at_@ -204,8 +204,10 @@ sub configured_nameservers {
> > > > > _at_ns_addr_port = @{$self->{conf}->{dns_servers}};
> > > > > dbg("dns: servers set by config to: %s", join(', ',_at_ns_addr_port));
> > > > > } elsif ($res) { # default as provided by Net::DNS, e.g. /etc/resolv.conf
> > > > > - _at_ns_addr_port = map(untaint_var("[$_]:" . $res->{port}),
> > > > > - _at_{$res->{nameservers}});
> > > > > + my _at_ns = $res->UNIVERSAL::can('nameservers') ? $res->nameservers
> > > > > + : _at_{$res->{nameservers}};
> > > > > + my $port = $res->UNIVERSAL::can('port') ? $res->port : $res->{port};
> > > > > + _at_ns_addr_port = map(untaint_var("[$_]:" . $port), @ns);
> > > > > dbg("dns: servers obtained from Net::DNS : %s", join(', ',_at_ns_addr_port));
> > > > > }
> > > > > return _at_ns_addr_port;
> > > >
> > > >
> > > >
> > > >
> > > > I took some time to figure out git a bit so I guess the following
> > > > attached patch is more accurate(?).
> > > >
> > > > Regards,
> > > > Johan
> > >
> > > Thanks.
> > > I applied it to edge, can you please check that it works as expected?
> > > Then I can backport it to 3.1-stable.
> > >
> > > For future patches it would be nice to have a GIT patch against aports
> > > tree. It would be more straightforward to apply them.
> > > Thanks!
> > >
> > > - leo
> >
> > I will test is as soon as the package shows up on the mirrors.
> >
> > However I have a problem downloading your aports git, getting the
> > following several times now:
> >
> > #> git clone http://git.alpinelinux.org/cgit/aports/
> >
> > # Cloning into 'aports'...
> > # error: Unable to get pack file
> > # http://git.alpinelinux.org/cgit/aports/objects/pack/pack-1f504ab51e1954e77d4841ca04d0a395bec1e1af.pack
> > # Recv failure: Connection timed out
> > # error: Unable to find e24b2cb6f0edf60b9bc766902715f25076ad591a under
> > # http://git.alpinelinux.org/cgit/aports
> > # Cannot obtain needed tree e24b2cb6f0edf60b9bc766902715f25076ad591a
> > # while processing commit 934775c391ac937f8c7a4f952cc7498df51abd7e.
> > # error: fetch failed.
> >
> > It's temporary perhaps. Are there any mirrors?
>
> May be is a web server issue. Have you tried
> git://git.alpinelinux.org/cgit/aports/ ?
>
>
> > If I have any future patches I will create them against the aports tree.
>
> Thanks!
>

The patched spamassassin is working as expected.

DNSBL lookups and scoring are all accurate. So I think you can push this
to the main repo.

Regards,
Johan

--Dxnq1zWXvFF0Q93v
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJUnLmoAAoJEAcoCTcJhy3fLmoP/RnVjGDv/7EojXe07rl0k9xR
unhnxGcw4hwXEkieMd7vmCPMKNKkTt9nTkLULB2PQ0vd5GmSLxAnHATdKo+QD+za
V9s+BdFHZAUe+e7SUCSHx89Lee7vJyauvzDjSB2XQ9UMPwgfwG7PihlkXINUJYqB
x/C+d/mS/d4tzwksX4d3mU4/LP4OHfQcKMc2bAUa3X54iceUhsGFgGXdIpfb2G5B
/V8QOy1DsYvBCs2JEGOLx/XqrTZpWgvuZxMh+f8nSYkA/nZL11RPmRYScOMOxZtk
i8gaQpY+act9s7XhSTtQ8rezTBWq63L6Kys/uhIQs5+cvlyglDxva1dYyMB/1mqf
iXAm3x4rVa64YC8T276AbhE4cMzm/BKy6QcGHrILggC+RcMMgB24n1eDYoC5K78n
E5XTceWqIWImyhrSEBeL/12ZA452rZ9037T1QwGad8YjAKgqJq9Ff4t5+II5vFeZ
E4ha2KtTG6Fu49z1Z1RaQtz5l6wFcWNyyE5E1MWFA/sVHpS2HuriPhL60j2y0Uqf
KO3DPHjtXEljgAsLYt8LQ1SnfKZb/HNn8rhvaH417FDGYjAsVqBJzsF0DFmTouLv
QVlwpRA3uruqRlo1wRHMUpweqIXHEvDh7esuJSqiYQMJBYO/S2aO9BseQXQunjmu
C5j/RdWbvFkfm5mOsNXh
=XmIW
-----END PGP SIGNATURE-----

--Dxnq1zWXvFF0Q93v--


---
Unsubscribe:  alpine-devel+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-devel+help_at_lists.alpinelinux.org
---
Received on Fri Dec 26 2014 - 03:28:09 GMT