Mail archive
alpine-devel

Re: [alpine-devel] busybox-1.23 in edge

From: Isaac Dunham <ibid.ag_at_gmail.com>
Date: Fri, 26 Dec 2014 11:03:28 -0800

On Fri, Dec 26, 2014 at 10:14:21AM +0100, Natanael Copa wrote:
> On Fri, 26 Dec 2014 09:05:15 +0100
> Natanael Copa <ncopa_at_alpinelinux.org> wrote:
>
> > On Thu, 25 Dec 2014 16:12:32 -0800
> > Isaac Dunham <ibid.ag_at_gmail.com> wrote:
> >
> > > On Thu, Dec 25, 2014 at 08:58:35PM +0100, Natanael Copa wrote:
> > > > Hi,
> > > >
> > > > I pushed busybox 1.23 to edge. So far I found at least one regression[1]
> > > > in ash and possibly another in modprobe.
> > > >
> > > > After upgrading my laptop (both new kernel and new busybox) it didn't
> > > > load the ahci kernel module from initramfs so the harddisks was not
> > > > found. I don't know if this is due to something in new busybox or in
> > > > new kernel or if it affects other hardware.
> >
> > It did happen on my desktop too and I have a theory on whats going on.
>
> ...
>
> > I think what happens is that if a slash (/) is found in the probe name,
> > modprobe will simply exit. We call it with: modprobe -a <alias1> <alias2> ...
> >
> > So it means it will load all modules up to first alias which contains a
> > slash and then stop.
> >
> > ncopa-desktop:~# find /sys -name uevent -exec grep -h MODALIAS= '{}' + 2>/dev/null | sort -u | grep -E 'pci|/'
> > MODALIAS=dmi:bvnDellInc.:bvrA07:bd09/10/2011:svnDellInc.:pnOptiPlex790:pvr01:rvnDellInc.:rn0HY9JP:rvrA00:cvnDellInc.:ct6:cvr:
> > MODALIAS=pci:v00008086d00000100sv00001028sd000004ADbc06sc00i00
> > MODALIAS=pci:v00008086d00000102sv00001028sd000004ADbc03sc00i00
> > ...
> >
> > As you see, there are slashes in the dmi module and since we sort, dmi
> > will always come before pci. So the disk controllers are never loaded
> > and disks never found.
> >
> > I think we should revert the upstream commit for now.
>
> I pushed a temp fix for busybox for now. I also bumped pkgrel for
> mkinitfs to force a regeneration with fixed busybox.
>
> The fixed was tested with success in qemu.

If there are slashes in some module aliases, the upstream commit is
based on a flawed assumption and should be reverted everywhere.


Thanks,
Isaac Dunham



---
Unsubscribe:  alpine-devel+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-devel+help_at_lists.alpinelinux.org
---
Received on Fri Dec 26 2014 - 11:03:28 GMT