Message-ID: <1484909802.8117.28.camel@gmail.com>
Subject: Re: [alpine-aports] [PATCH v2] main/nano: Ditch empty vars in
 APKBUILD. Change maintainer.
From: Leonardo Arena <rnalrd@gmail.com>
To: =?UTF-8?Q?Przemys=C5=82aw_Pawe=C5=82czyk?= <przemoc@zoho.com>
Cc: ncopa@alpinelinux.org, alpine-aports@lists.alpinelinux.org, 
	zhoumichaely@gmail.com
Date: Fri, 20 Jan 2017 11:56:42 +0100
In-Reply-To: <159b359c343.df2494d47904.5259965377121748158@zoho.com>
References: <20170114005016.27359-1-przemoc@zoho.com>
	 <20170114194146.26046-1-przemoc@zoho.com>
	 <1484744349.8117.5.camel@gmail.com>
	 <159b359c343.df2494d47904.5259965377121748158@zoho.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-QQpY0ZebDxYyhhCHMH+T"
Precedence: list
Mime-Version: 1.0


--=-QQpY0ZebDxYyhhCHMH+T
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On mer, 2017-01-18 at 21:52 +0100, Przemys=C5=82aw Pawe=C5=82czyk wrote:
> Hi!
>=20
> =C2=A0---- On Wed, 18 Jan 2017 13:59:09 +0100 Leonardo Arena <rnalrd@gmai=
l
> .com> wrote ----=C2=A0
> =C2=A0> On sab, 2017-01-14 at 20:41 +0100, Przemyslaw Pawelczyk wrote:=C2=
=A0
> =C2=A0> > Old alleged maintainer (Michael Zhou) made himself maintainer
> with=C2=A0
> =C2=A0> > commit d2f2f034f33f4c6d8df8573da9455b475f6550f6, but he never
> touched=C2=A0
> =C2=A0> > nano ever again.=C2=A0=C2=A0He has almost no trace of any activ=
ity in
> aports=C2=A0
> =C2=A0> > repo=C2=A0
> =C2=A0> > since 2011 (1 commit in 2016).=C2=A0
> =C2=A0> >=C2=A0=C2=A0
> =C2=A0> > Natanael Copa is the most active contributor, so hopefully he's
> not=C2=A0
> =C2=A0> > against becoming maintainer of another package.=C2=A0
> =C2=A0> > ---=C2=A0
> =C2=A0> >=C2=A0=C2=A0
> =C2=A0> > =C5=81ukasz Jendrysik was not aware of my nano upgrade in patch=
work,=C2=A0
> =C2=A0> > so he did PR in github and Jakub Jirutka applied it quickly
> then.=C2=A0
> =C2=A0> > Here is the remaining part of my original patch.=C2=A0
> =C2=A0> >=C2=A0=C2=A0
> =C2=A0> >=C2=A0=C2=A0
> =C2=A0> >=C2=A0=C2=A0main/nano/APKBUILD | 5 ++---=C2=A0
> =C2=A0> >=C2=A0=C2=A01 file changed, 2 insertions(+), 3 deletions(-)=C2=
=A0
> =C2=A0> >=C2=A0=C2=A0
> =C2=A0> > diff --git a/main/nano/APKBUILD b/main/nano/APKBUILD=C2=A0
> =C2=A0> > index 3bbd36ac9945..ccdfc2f661d9 100644=C2=A0
> =C2=A0> > --- a/main/nano/APKBUILD=C2=A0
> =C2=A0> > +++ b/main/nano/APKBUILD=C2=A0
> =C2=A0> > @@ -1,13 +1,12 @@=C2=A0
> =C2=A0> >=C2=A0=C2=A0# Contributor: Michael Mason <ms13sp@gmail.com>=C2=
=A0
> =C2=A0> > -# Maintainer: Michael Zhou <zhoumichaely@gmail.com>=C2=A0
> =C2=A0> > +# Maintainer: Natanael Copa <ncopa@alpinelinux.org>=C2=A0
> =C2=A0> >=C2=A0=C2=A0pkgname=3Dnano=C2=A0
> =C2=A0> >=C2=A0=C2=A0pkgver=3D2.7.4=C2=A0
> =C2=A0> > -pkgrel=3D0=C2=A0
> =C2=A0> > +pkgrel=3D1=C2=A0
> =C2=A0>=C2=A0=C2=A0
> =C2=A0> I don't think we need to really rebuild the package for this.
> Hence=C2=A0
> =C2=A0> pkgrel can be left untouched.=C2=A0
>=20
> AFAIK pkgs.alpinelinux.org updates its info when the package is
> built, therefore I think it's good to bump pkgrel. Changing
> maintainer should be reflected in AL services.
> =C2=A0

It makes sense.

> In the old days (not that long ago) ncopa requested that each change
> in APKBUILD should lead to pkgrel bump, which is a safe and sane
> approach, even if a bit wasteful.
>=20
> Some time ago APKBUILD improvements started to be applied without
> pkgrel bump, which can be acceptable in case of trivial changes (like
> my removal of empty vars here and there), but shouldn't be acceptable
> in general (like _builddir -> builddir rename and prepare() removal,
> because different code path in abuild is performed then).
>=20

Agree

> Changing maintainer, while being trivial in diff, is important
> change, thus I strongly suggest to not drop pkgrel bump from this
> patch.
>=20

Accepted as is. :-)

Thanks!

-|_eo

--=-QQpY0ZebDxYyhhCHMH+T
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAABCAAGBQJYgezqAAoJELAPckZGG2T6CnUH/RXaPVtNdFXSJct16im3vG+H
0gNPhAzuwPtrEHuVWRgd8qTqCVdKyjTF/9MIAuY+S5aIWf68tKx7lR/HSeRPY5jS
vwldkDtfA/LczC/JDIPlF6sH1d0KRmCq89SkvlG6p1oCtfR+hz99XS9i94PKt8/J
vxEXcOCz8HTv9yaeiyiXwMfJSx/Q4Hz2dEYEQFliCuc1tyMAaJkDcqVqrfUbH+p3
z7RTm7rrGDAHyirX8zy14jUzw93y+lWO4TGWvnaVhg9A07EzxkyoaEOyx0LfdVKE
3l7WwoIRDCz6t68LVZbTpiA3eiGQTEvWYXvKp3j8JRuhXPUwK3dgTtyp79rKQpY=
=3cxQ
-----END PGP SIGNATURE-----

--=-QQpY0ZebDxYyhhCHMH+T--



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---