X-Original-To: alpine-aports@mail.alpinelinux.org Delivered-To: alpine-aports@mail.alpinelinux.org Received: from mail.alpinelinux.org (dallas-a1.alpinelinux.org [127.0.0.1]) by mail.alpinelinux.org (Postfix) with ESMTP id 751B1DC01F2; Tue, 5 May 2015 12:50:59 +0000 (UTC) Received: from ncopa-desktop.alpinelinux.org (unknown [79.160.13.133]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: n@tanael.org) by mail.alpinelinux.org (Postfix) with ESMTPSA id BD51ADC0082; Tue, 5 May 2015 12:50:58 +0000 (UTC) Date: Tue, 5 May 2015 14:50:55 +0200 From: Natanael Copa To: Stuart Cardall Cc: alpine-aports@lists.alpinelinux.org Subject: Re: [alpine-aports] [PATCH 3/3] testing/udevil: new aport Message-ID: <20150505145055.2dcecc77@ncopa-desktop.alpinelinux.org> In-Reply-To: <1430785588-65737-3-git-send-email-developer@it-offshore.co.uk> References: <1430785588-65737-1-git-send-email-developer@it-offshore.co.uk> <1430785588-65737-3-git-send-email-developer@it-offshore.co.uk> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-alpine-linux-musl) X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP On Tue, 5 May 2015 00:26:28 +0000 Stuart Cardall wrote: > +++ b/testing/udevil/udevil.post-install > @@ -0,0 +1,22 @@ > +#!/bin/sh > + > +NORMAL="\033[1;0m" > +STRONG="\033[1;1m" > +GREEN="\033[1;32m" > + > +print_strong() { > + local prompt="${STRONG}$1 ${GREEN}$2${NORMAL}" > + printf "${prompt} %s\n" > +} > + > +print_strong "\nTo mount / unmount devices without the root password:" " add your user account to the 'plugdev' group." > +print_strong "\nOptional dependencies:" > +print_strong "\nzenity: " " (devmon popups)" > +print_strong "davfs2: " " (mount WebDAV resources)" > +print_strong "cifs-utils: " " (mounting samba shares)" > +print_strong "curlftpfs: " " (mounting ftp shares)" > +print_strong "nfs-utils: " " (mounting nfs shares)" > +print_strong "sshfs-fuse: " " (mounting sftp shares)" > +print_strong "eject: " " (eject via devmon)" > +exit 0 > + I am not sure I like the post-install script. - There is no guarantee that there are color support. (think: apk add $packages > logfile) - There is no guarantee user reach to read it. package might be installed together with 100 other packages. - It is meaningless to show this message every reboot. (tmpfs install) - If every package did something like this it would slow down the install. Can we remove the post-install and create a doc on the wiki instead? If we want this kind of informative messages for installed packages, then we should consider add this as a feature for apk-tools or similar. The message should be displayed after install (maybe via trigger?) and maybe we want be able to read the message long time after package was installed. Maybe store them as /usr/share/apk-tools/$pkgname/post-install-message or similar. In any case, I don't like doing it from post-install. -nc --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---