Date: Thu, 4 Jun 2015 10:01:54 +0200
From: Natanael Copa <ncopa@alpinelinux.org>
To: Andrew Hills <ahills@ednos.net>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH] testing/terminus-font: new aport
Message-ID: <20150604100154.5ca130a1@ncopa-desktop.alpinelinux.org>
In-Reply-To: <1432480436-16702-1-git-send-email-ahills@ednos.net>
References: <1432480436-16702-1-git-send-email-ahills@ednos.net>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Sun, 24 May 2015 11:13:56 -0400
Andrew Hills <ahills@ednos.net> wrote:

> http://sourceforge.net/projects/terminus-font/
> Monospace bitmap font (for X11 and console)
> 
> This is actually Orion's APKBUILD, with the missing makedepend
> "grep" added to allow the build to succeed. Busybox's "grep"
> command does not support the regular expression from the package's
> micro-configure script on line 42.
> ---

Thanks for this patch.

I think it needs a bit more cleanup. Please see comments below.

...
> +depends="fontconfig libfontenc font-util"

Are those actually needed to use the font at runtime? is not a font just static data?

...

> --- /dev/null
> +++ b/testing/terminus-font/terminus-font.post-install
> @@ -0,0 +1,6 @@
> +#!/bin/sh
> +# add something which happends after install
> +
> +fc-cache -s
> +mkfontscale usr/share/fonts/misc
> +mkfontdir usr/share/fonts/misc

We have a trigger to do the fc-cache. I think the post-install can simply be removed.

-nc


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---