X-Original-To: alpine-aports@mail.alpinelinux.org
Delivered-To: alpine-aports@mail.alpinelinux.org
Received: from mail.alpinelinux.org (dallas-a1.alpinelinux.org [127.0.0.1])
	by mail.alpinelinux.org (Postfix) with ESMTP id 3345BDC67C9
	for <alpine-aports@mail.alpinelinux.org>; Wed,  9 Sep 2015 19:32:41 +0000 (UTC)
Received: from lithium.8pit.net (lithium.8pit.net [141.101.32.65])
	(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.alpinelinux.org (Postfix) with ESMTPS id AF4A6DC5DD6
	for <alpine-aports@lists.alpinelinux.org>; Wed,  9 Sep 2015 19:32:40 +0000 (UTC)
Received: from localhost (ip5f5ac959.dynamic.kabel-deutschland.de [95.90.201.89]);
	by lithium.8pit.net (OpenSMTPD) with ESMTPSA id 85595b19;
	TLS version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO;
	for <alpine-aports@lists.alpinelinux.org>;
	Wed, 9 Sep 2015 21:32:37 +0200 (CEST)
Date: Wed, 9 Sep 2015 21:32:33 +0200
From: =?iso-8859-1?Q?S=F6ren?= Tempel <soeren@soeren-tempel.net>
To: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH v3] testing/fbida: new aport
Message-ID: <20150909193233.GA2141@francium.lan>
References: <1441655200-7825-1-git-send-email-soeren+git@soeren-tempel.net>
 <1441658551-17451-1-git-send-email-soeren+git@soeren-tempel.net>
 <20150909054851.GB2695@newbook>
X-Mailinglist: alpine-aports
Precedence: list
List-Id: Alpine Development <alpine-aports.lists.alpinelinux.org>
List-Unsubscribe: 
	<mailto:alpine-aports+unsubscribe@lists.alpinelinux.org?subject=unsubscribe>
List-Post: <mailto:alpine-aports@lists.alpinelinux.org>
List-Help: <mailto:alpine-aports+help@lists.alpinelinux.org?subject=help>
List-Subscribe: 
	<mailto:alpine-aports+subscribe@lists.alpinelinux.org?subject=subscribe>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20150909054851.GB2695@newbook>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-Virus-Scanned: ClamAV using ClamSMTP

On 08.09.15, Isaac Dunham wrote:
> Now, a couple comments on substance:
> - the use of _tool and _tool_doc is rather odd, but there's only one point
> where I'd actually suggest something different:
> for fbida-fbgs, call a new function "fbgs", which will in turn call _tool.

I think the _tool and _tool_doc functions are a nice way to prevent
duplication. Creating a new "fbgs" function which invokes _tool sounds
like a good idea to me, but both approaches work and don't make a big
difference to me.

On 08.09.15, Isaac Dunham wrote:
> - package naming is somewhat odd, and it's certainly more granular than
> usual: the usual split is fbi / ida (+ -doc for each)

The fbida website <https://www.kraxel.org/blog/linux/fbida/>
differentiates between 5 Tools. Therefore it seemed very intuitive to me
to also create a subpackage for each of those tools, even though I
didn't package thumbnail.cgi yet.

Since it's pretty easy to split the package with the _tool
function I don't see any reason not to do it. It might be unusual but I
think it's the best way to split it.

On 08.09.15, Isaac Dunham wrote:
> - RESDIR should not be set to /usr/share/$pkgname:
> no one would think to look for the application defaults there.
> The standard location is /etc/X11/app-defaults/<resource name>.

You are right, I will fix that tomorrow. Furthermore that file should
probably be moved to the ida subpackage.

S=F6ren.


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---