Date: Tue, 15 Sep 2015 10:37:42 +0200
From: Natanael Copa <ncopa@alpinelinux.org>
To: "PAN, Myautsai" <myautsai@gmail.com>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH] testing/openconnect: new aport
Message-ID: <20150915103742.6a398cac@ncopa-desktop.alpinelinux.org>
In-Reply-To: <1442078171-36189-1-git-send-email-myautsai@gmail.com>
References: <1442078171-36189-1-git-send-email-myautsai@gmail.com>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Sun, 13 Sep 2015 01:16:11 +0800
"PAN, Myautsai" <myautsai@gmail.com> wrote:

> From: mckelvin <mckelvin@users.noreply.github.com>
> 
> http://www.infradead.org/openconnect/
> Open client for Cisco AnyConnect VPN
> ---
>  testing/openconnect/APKBUILD | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
>  create mode 100644 testing/openconnect/APKBUILD

Thanks for this patch, but it does not build:

checking for OPENSSL... no
checking for OpenSSL without pkg-config... no
configure: error: Could not build against OpenSSL
make: *** No targets specified and no makefile found.  Stop.


> 
> diff --git a/testing/openconnect/APKBUILD b/testing/openconnect/APKBUILD
> new file mode 100644
> index 0000000..4bdc4f2
> --- /dev/null
> +++ b/testing/openconnect/APKBUILD
> @@ -0,0 +1,33 @@
> +# Contributor: Myautsai PAN <myautsai@gmail.com>
> +# Maintainer: Myautsai PAN <myautsai@gmail.com>
> +
> +pkgname=openconnect
> +pkgver=7.06
> +pkgrel=2
> +pkgdesc="Open client for Cisco AnyConnect VPN"
> +url="http://www.infradead.org/openconnect/"
> +arch="all"
> +license="LGPL2.1"
> +depends="libxml2 gnutls libproxy vpnc krb5 lz4 openssl"

abuild will automatically pull in the needed runtime dependencies for
shared libraries so you will most likely not need the libxml2, gnutls
etc dependencies listed there.

> +depends_dev="libxml2-dev gnutls-dev libproxy-dev vpnc krb5-dev lz4-dev openssl-dev gettext"
> +makedepends="intltool python"

depends_dev will only be added as dependency for a -dev subpackage.
Since there are no subpackages in this case, the depends_dev is
meaningless.

I believe you need to move all the packages in depends_dev to makedepends.

I am also not sure if gettext dep is needed?

Care to send a v2 patch?

http://wiki.alpinelinux.org/wiki/Creating_patches#Resend_an_updated_patch

-nc


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---