X-Original-To: alpine-aports@mail.alpinelinux.org
Delivered-To: alpine-aports@mail.alpinelinux.org
Received: from mail.alpinelinux.org (dallas-a1.alpinelinux.org [127.0.0.1])
	by mail.alpinelinux.org (Postfix) with ESMTP id 32602DC2C02
	for <alpine-aports@mail.alpinelinux.org>; Thu, 15 Oct 2015 07:32:56 +0000 (UTC)
Received: from newmail.tetrasec.net (unknown [74.117.189.116])
	by mail.alpinelinux.org (Postfix) with ESMTP id 162D0DC00AF
	for <alpine-aports@lists.alpinelinux.org>; Thu, 15 Oct 2015 07:32:56 +0000 (UTC)
Received: from ncopa-desktop.alpinelinux.org (unknown [79.160.13.133])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: n@tanael.org)
	by newmail.tetrasec.net (Postfix) with ESMTPSA id 15D415A7F3A;
	Thu, 15 Oct 2015 07:22:27 +0000 (GMT)
Date: Thu, 15 Oct 2015 09:32:52 +0200
From: Natanael Copa <ncopa@alpinelinux.org>
To: "PAN, Myautsai" <myautsai@gmail.com>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH v2] testing/openconnect: new aport
Message-ID: <20151015093252.7f5c019e@ncopa-desktop.alpinelinux.org>
In-Reply-To: <1444221059-5468-1-git-send-email-myautsai@gmail.com>
References: <1442078171-36189-1-git-send-email-myautsai@gmail.com>
	<1444221059-5468-1-git-send-email-myautsai@gmail.com>
X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-alpine-linux-musl)
X-Mailinglist: alpine-aports
Precedence: list
List-Id: Alpine Development <alpine-aports.lists.alpinelinux.org>
List-Unsubscribe: 
	<mailto:alpine-aports+unsubscribe@lists.alpinelinux.org?subject=unsubscribe>
List-Post: <mailto:alpine-aports@lists.alpinelinux.org>
List-Help: <mailto:alpine-aports+help@lists.alpinelinux.org?subject=help>
List-Subscribe: 
	<mailto:alpine-aports+subscribe@lists.alpinelinux.org?subject=subscribe>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: ClamAV using ClamSMTP

On Wed,  7 Oct 2015 20:30:59 +0800
"PAN, Myautsai" <myautsai@gmail.com> wrote:

> From: mckelvin <mckelvin@users.noreply.github.com>
> 
> http://www.infradead.org/openconnect/
> Open client for Cisco AnyConnect VPN

Sorry for not reading patch more careful last time.
> ---
>  testing/openconnect/APKBUILD | 34 ++++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>  create mode 100644 testing/openconnect/APKBUILD
> 
> diff --git a/testing/openconnect/APKBUILD b/testing/openconnect/APKBUILD
> new file mode 100644
> index 0000000..f8c6bd0
> --- /dev/null
> +++ b/testing/openconnect/APKBUILD
> @@ -0,0 +1,34 @@
> +# Contributor: Myautsai PAN <myautsai@gmail.com>
> +# Maintainer: Myautsai PAN <myautsai@gmail.com>
> +
> +pkgname=openconnect
> +pkgver=7.06
> +pkgrel=2
> +pkgdesc="Open client for Cisco AnyConnect VPN"
> +url="http://www.infradead.org/openconnect/"
> +arch="all"
> +license="LGPL2.1"
> +depends="libxml2 libproxy vpnc krb5 lz4 openssl"

depends looks wrong. abuild will automatically detect the shared libs
dependencies. It will not be able to detect if a script needs a
program, so if openconnect needs /usr/bin/openssl and similar then the
package that contains the program will need to be in depends. Otherwise
depends should be empty.

After building the package you can check with 'apk info -R openconnect'
to see what it pulled in as dependencies. (note that shared libs will
also automatically have a "so:<SONAME>" provides. that way we can
rename packages or move libs to different sub packages without needing
to depends everywhere)

Can you please send a v3 of the patch?

thanks!

> +makedepends="autoconf automake intltool python openssl-dev libxml2-dev lz4-dev libproxy-dev"
> +source="ftp://ftp.infradead.org/pub/$pkgname/$pkgname-$pkgver.tar.gz"
> +
> +_builddir=$srcdir/$pkgname-$pkgver
> +build() {
> +    cd $_builddir
> +    ./configure --prefix=/usr \
> +        --sbindir=/usr/bin \
> +        --disable-static \
> +        --without-gnutls \
> +        --disable-nls
> +    sed -i -r 's/\/\* #undef ICONV_CONST \*\//#define ICONV_CONST/' config.h
> +    make
> +}
> +
> +package() {
> +    cd $_builddir
> +    make DESTDIR="$pkgdir" install
> +}
> +
> +md5sums="80f397911e1fed43d897d99be3d5f1a1  openconnect-7.06.tar.gz"
> +sha256sums="facf695368dc4537a6a30e2147be90b1d77ee3cb2d269eaef070b6d9ddab70f2  openconnect-7.06.tar.gz"
> +sha512sums="d1af9efe4ac1f6671dc6b92db0df981e8cae3f2f50b8b4c35a112b42a76517b7c8ea9fd5da93352445dd61da3012bf34fdbcc3add9d8727cbaad7d311e516108  openconnect-7.06.tar.gz"



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---