Date: Mon, 26 Oct 2015 10:22:59 +0100
From: Natanael Copa <ncopa@alpinelinux.org>
To: =?ISO-8859-1?B?U/ZyZW4=?= Tempel <soeren+git@soeren-tempel.net>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH 2/3] main/dropbear: use configure
 options from newapkbuild autoconf template
Message-ID: <20151026102259.20c7b89d@ncopa-desktop.alpinelinux.org>
In-Reply-To: <1445780660-2520-2-git-send-email-soeren+git@soeren-tempel.net>
References: <1445780660-2520-1-git-send-email-soeren+git@soeren-tempel.net>
	<1445780660-2520-2-git-send-email-soeren+git@soeren-tempel.net>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Sun, 25 Oct 2015 14:44:19 +0100
S=F6ren Tempel <soeren+git@soeren-tempel.net> wrote:

> ---
>  main/dropbear/APKBUILD | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
>=20
> diff --git a/main/dropbear/APKBUILD b/main/dropbear/APKBUILD
> index 49dd67c..bbbff79 100644
> --- a/main/dropbear/APKBUILD
> +++ b/main/dropbear/APKBUILD
> @@ -1,3 +1,4 @@
> +# Contributor: S=F6ren Tempel <soeren+alpine@soeren-tempel.net>
>  # Contributor: Carlo Landmeter <clandmeter@gmail.com>
>  # Maintainer: Natanael Copa <ncopa@alpinelinux.org>
>  pkgname=3Ddropbear
> @@ -6,16 +7,16 @@ pkgrel=3D1
>  pkgdesc=3D"small SSH 2 client/server designed for small memory environme=
nts"
>  url=3D"http://matt.ucc.asn.au/dropbear/dropbear.html"
>  arch=3D"all"
> -license=3D'MIT'
> -depends=3D
> +license=3D"MIT"
> +depends=3D""
> +depends_dev=3D""
>  makedepends=3D"zlib-dev linux-headers"
>  subpackages=3D"$pkgname-doc $pkgname-scp:_scp"
>  source=3D"http://matt.ucc.asn.au/dropbear/releases/${pkgname}-${pkgver}.=
tar.bz2
>  	dropbear.initd
>  	dropbear.confd
>  	dropbear-0.53.1-static_build_fix.patch
> -	dropbear-options_sftp-server_path.patch
> -	"
> +	dropbear-options_sftp-server_path.patch"

FWIW, having the closing " on separate line makes it easier to
add/remove patches (eg stable maintenance). If an update in future
include the dropbear-options_sftp-server_path.patch then I just 'dd' in
vim and move on. Now I will have to 'dd' and then append a closing ".

I know it is a nit-pick, but after adding/removing 1000+ patches those
trivial extra file edits becomes annoying.

>  _builddir=3D"$srcdir"/$pkgname-$pkgver
>  _progs=3D"dropbear dbclient dropbearkey dropbearconvert scp"
> @@ -36,6 +37,10 @@ build() {
>  		--build=3D$CBUILD \
>  		--host=3D$CHOST \
>  		--prefix=3D/usr \
> +		--sysconfdir=3D/etc \
> +		--mandir=3D/usr/share/man \
> +		--infodir=3D/usr/share/info \

I'm not really sure about the value of adding infodir since its not
used anyway. We should probably remove it from the newapkbuild template.

> +		--localstatedir=3D/var \
>  		|| return 1
>  	make PROGRAMS=3D"$_progs" MULTI=3D1 || return 1
>  }



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---