Sender: =?UTF-8?Q?Timo_Ter=C3=A4s?= <timo.teras@gmail.com>
Date: Tue, 19 Jan 2016 13:51:53 +0200
From: Timo Teras <timo.teras@iki.fi>
To: =?UTF-8?B?U8O2cmVu?= Tempel <soeren+git@soeren-tempel.net>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH v2] main/logrotate: update urls
Message-ID: <20160119135153.6a4f5c18@vostro>
In-Reply-To: <1452187279-6432-1-git-send-email-soeren+git@soeren-tempel.net>
References: <1451784707-924-1-git-send-email-soeren+git@soeren-tempel.net>
	<1452187279-6432-1-git-send-email-soeren+git@soeren-tempel.net>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Thu,  7 Jan 2016 18:21:19 +0100
S=C3=B6ren Tempel <soeren+git@soeren-tempel.net> wrote:

> https://fedorahosted.org/logrotate/ states that logrotate upstream has
> been moved to GitHub. The old trac page is no longer updated.
> ---
>  main/logrotate/APKBUILD | 20 ++++++++------------
>  1 file changed, 8 insertions(+), 12 deletions(-)
>=20
> diff --git a/main/logrotate/APKBUILD b/main/logrotate/APKBUILD
> index 020a4c3..2a65fcf 100644
> --- a/main/logrotate/APKBUILD
> +++ b/main/logrotate/APKBUILD
> @@ -2,28 +2,24 @@
>  # Maintainer: Natanael Copa <ncopa@alpinelinux.org>
>  pkgname=3Dlogrotate
>  pkgver=3D3.9.1
> +_relver=3D"r$(echo $pkgver | tr '.' '-')"

This forks and is slow. Shell substitution works on simple things. That
is ${pkgver//./-}.

>  pkgrel=3D1

And pkgrel needs a bump.

>  pkgdesc=3D"Tool to rotate logfiles"
> -url=3D"https://fedorahosted.org/logrotate/"
> +url=3D"https://github.com/logrotate/logrotate"
>  arch=3D"all"
>  license=3D"GPL2"
>  depends=3D""
>  makedepends=3D"popt-dev autoconf automake libtool"
>  subpackages=3D"$pkgname-doc"
> -source=3D"https://fedorahosted.org/releases/l/o/logrotate/logrotate-$pkg=
ver.tar.gz
> +source=3D"$pkgname-$pkgver.tar.gz::https://github.com/${pkgname}/${pkgna=
me}/archive/${_relver}.tar.gz

The tarball is different in github. The filename should be different. I
used $pkgname-$_relver.tar.gz here instead.

Made the above changes, and pushed.

Thanks!

>  	logrotate.cron
>  	logrotate.conf
>  	logrotate.confd"
> =20
> -_builddir=3D"$srcdir/$pkgname-$pkgver"
> +_builddir=3D"$srcdir"/$pkgname-$_relver
>  prepare() {
>  	cd "$_builddir"
> -	for i in $source; do
> -		case $i in
> -		*.patch) msg $i; patch -p1 -i "$srcdir"/$i || return
> 1;;
> -		esac
> -	done
> -	./autogen.sh
> +	./autogen.sh || return 1
>  }
> =20
>  build() {
> @@ -50,15 +46,15 @@ package() {
>  		"$pkgdir"/etc/conf.d/logrotate
>  }
> =20
> -md5sums=3D"4492b145b6d542e4a2f41e77fa199ab0  logrotate-3.9.1.tar.gz
> +md5sums=3D"8572b7c2cf9ade09a8a8e10098500fb3  logrotate-3.9.1.tar.gz
>  7e9fad2c9b382a2370c11ef0c89f61c7  logrotate.cron
>  dbe6b14d5265e32f8e1b655ae34ae3a3  logrotate.conf
>  e7e4b67d5c4bda49ff3c041834180c1e  logrotate.confd"
> -sha256sums=3D"022769e3288c80981559a8421703c88e8438b447235e36dd3c8e97cd94=
c52545
> logrotate-3.9.1.tar.gz
> +sha256sums=3D"5bf8e478c428e7744fefa465118f8296e7e771c981fb6dffb7527856a0=
ea3617
> logrotate-3.9.1.tar.gz
> ccbcf1785c754ce07a55b81223ae5b0c2caec1ccf9cdf865debb140052f9b363
> logrotate.cron
> 4ceb3045968a7bc539a808821fb7ca03521806153b012bdb3800e1811d2772f9
> logrotate.conf
> 814bea9082cfa3a9446e25f4f4fe4fe205130cea6ba15dc8286409c3d01a3973
> logrotate.confd"
> -sha512sums=3D"e6da7c7f067befaf2441e9c6ce77e53cf5ddb4f56cc3304c3e50873b6f=
20c68520f4a0e50ec466cbebcbed20bfd77bf6dfc489975a8131e9573fb19856c0fe28
> logrotate-3.9.1.tar.gz
> +sha512sums=3D"f97fbbff69e0ec711a1a3d66d75823feb7db0356a019b365d1a1e87229=
7c7792f3b4f4d8cb4e0a069aac7dcd0809e3da2d4fc0eef0c4e5bd2180a7a4c67dc19b
> logrotate-3.9.1.tar.gz
> f4d708594fb2b240cfc2928f38a180d27c2cecb9867e048dc29a32c0147244db4d2f6d92e=
7bff27e1f2623537587db87b2f8fc9bb988f98eff0c98f79f5a5bf2
> logrotate.cron
> a21f664cee9a3fa01c207fe126cef85d127c90ea012f4ecde47396ec1139dd489c04f92d5=
075fc1b0cbcc604af84c2ff01dccdaeca630db088c2f6e521fabe82
> logrotate.conf
> be9f0043b594d26b4f64e07a2188d19c3c43af75ef726305e4d98f744fc16cee9f2802271=
16858e2f5b781c0a7b58e0209d7e9ab1285dfa7ba55a9dfda700229
> logrotate.confd"



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---