Sender: =?UTF-8?Q?Timo_Ter=C3=A4s?= <timo.teras@gmail.com>
Date: Tue, 19 Jan 2016 14:44:36 +0200
From: Timo Teras <timo.teras@iki.fi>
To: Valery Kartel <valery.kartel@gmail.com>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH] testing/libmbfl: new aport
Message-ID: <20160119144436.212a9da7@vostro>
In-Reply-To: <1452610023-5526-1-git-send-email-valery.kartel@gmail.com>
References: <1452610023-5526-1-git-send-email-valery.kartel@gmail.com>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 12 Jan 2016 16:47:03 +0200
Valery Kartel <valery.kartel@gmail.com> wrote:

> This is Libmbfl, a streamable multibyte character code filter and
> converter library.

Most this looks good.

However, the cmake configure phase downloads stuff:

-- Looking for strchr
-- Looking for strchr - found
-- Downloading 8859-1.TXT
-- Downloading 8859-2.TXT
-- Downloading 8859-3.TXT
-- Downloading 8859-4.TXT
-- Downloading 8859-5.TXT
-- Downloading 8859-6.TXT
-- Downloading 8859-7.TXT
-- Downloading 8859-8.TXT
-- Downloading 8859-9.TXT
-- Downloading 8859-10.TXT
-- Downloading 8859-11.TXT
-- Downloading 8859-13.TXT
-- Downloading 8859-14.TXT
-- Downloading 8859-15.TXT
-- Downloading 8859-16.TXT
-- Downloading EastAsianWidth.txt
-- Configuring done
-- Generating done

Could you look at the cmake, and ship the required files in aports, or
at least provide versioned download links for abuild to fetch these
files.

We generally prefer the configure/build stage to not download anything.
The download links should be static so we can do reproducable builds.

Thanks,
Timo


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---