Sender: =?UTF-8?Q?Timo_Ter=C3=A4s?= <timo.teras@gmail.com>
Date: Tue, 19 Jan 2016 14:49:18 +0200
From: Timo Teras <timo.teras@iki.fi>
To: Thomas Weisshaar <thomas.weisshaar@gmail.com>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH] testing/dumb-init: new aport
Message-ID: <20160119144918.5e341ee5@vostro>
In-Reply-To: <6E9D42CE-4FAC-48AB-96B4-0614921B7BB8@gmail.com>
References: <1452614097-7180-1-git-send-email-thomas.weisshaar@gmail.com>
	<6E9D42CE-4FAC-48AB-96B4-0614921B7BB8@gmail.com>
Precedence: list
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 boundary="Sig_/JWCJeSKCG.h83Ph=5oELDFc"; protocol="application/pgp-signature"

--Sig_/JWCJeSKCG.h83Ph=5oELDFc
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

On Wed, 13 Jan 2016 01:38:06 +0100
Thomas Weisshaar <thomas.weisshaar@gmail.com> wrote:

> https://github.com/Yelp/dumb-init=20
> A minimal init system for Linux containers

Seems your email client messed up the patch somehow?

I get:
>>> dumb-init: Checking sanity
>>> of /home/tteras/aports/testing/dumb-init/APKBUILD... ERROR:
>>> dumb-init: v1.0.0.zip> is missing in checksums

And the patch indeed has lots of <mailto:> and <https:> links added to
it.

See also below.

> testing/dumb-init/APKBUILD | 34 ++++++++++++++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
> create mode 100644 testing/dumb-init/APKBUILD
>=20
> diff --git a/testing/dumb-init/APKBUILD b/testing/dumb-init/APKBUILD
> new file mode 100644
> index 0000000..5cd0a2e
> --- /dev/null
> +++ b/testing/dumb-init/APKBUILD
> @@ -0,0 +1,34 @@
> +# Contributor: Thomas Weisshaar <Thomas.Weisshaar@gmail.com
> <mailto:Thomas.Weisshaar@gmail.com>> +# Maintainer: Thomas Weisshaar
> <Thomas.Weisshaar@gmail.com <mailto:Thomas.Weisshaar@gmail.com>>
> +pkgname=3Ddumb-init +pkgver=3D1.0.0
> +pkgrel=3D0
> +pkgdesc=3D"A minimal init system for Linux containers"
> +url=3D"https://github.com/Yelp/dumb-init
> <https://github.com/Yelp/dumb-init>" +arch=3D"all"
> +license=3D"MIT"
> +depends=3D""
> +depends_dev=3D""
> +makedepends=3D"$depends_dev"
> +install=3D""
> +subpackages=3D""
> +source=3D"https://github.com/Yelp/$pkgname/archive/v$pkgver.zip
> <https://github.com/Yelp/$pkgname/archive/v$pkgver.zip>" +

You should use the "saveas" feature here, as the builders cache files
uniquely by name.

Use in source something like:
$pkgname-$pkgver.zip::https://github.com/Yelp...

See other APKBUILD files for more info on the '::' syntax. Like
main/cpulimit.

Otherwise it looks good.

Thanks,
Timo

> +_builddir=3D"$srcdir"/$pkgname-$pkgver
> +prepare() {
> +	return 0
> +}
> +
> +build() {
> +	cd "$_builddir"
> +	make || return 1
> +}
> +
> +package() {
> +	cd "$_builddir"
> +        install -m755 -D "${_builddir}/dumb-init"
> "${pkgdir}/usr/sbin/dumb-init" || return 1 +}
> +
> +md5sums=3D"ac5fbbd194366aab8b97547f34a7b7a8  v1.0.0.zip"
> +sha256sums=3D"bad6d7184d0ead914637101ecbd2979fa08b197a3d947d5ddd1acfb5ea=
4994d4
> v1.0.0.zip"
> +sha512sums=3D"9a6635562fc716a9319e3ea64bc02da0cebdec0e69b6887e7b67edb868=
1d8b9eae77f913f8429bb0e61d7301d97602dbce11b3a1af2e292bd634745da03d5489
> v1.0.0.zip"


--Sig_/JWCJeSKCG.h83Ph=5oELDFc
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJWnjDOAAoJEDQff6LfmTzCSRgP/Ahu+eGFVnZPewnW7yr9npOf
RgKpTweslihgqmmWIj6Fu2/wJhPxjuLNGsjMa962AiUM5Gj7WQ0NhaT8bhc8aTsn
fShPOwex9ivic7NavOqv1zKC9hDJYUsf/YOhuUqYgu71+PEMjszzL+70Zp7EbHlu
ePnhRR7zdXfA1YszO+NPzOdot9rBX5Pp0MIKCdqoUWX++8YFiLZlS/a+S5qYeVFB
v4fssRt41e3Se6UaZM8nsx+we1KZTRmPbv2GLKJXvsnIkeOSrGk/nbbdfStx2A9J
gfX2HTzOagtMobHZ5pUS2CLYRxljGMzYqarbsApKzqoz1BjdvugMAK7j/XoCrGiz
7SDeQTiwvdlsedlDJXYd3hFS82Id57b4uwCV4hjhrvx7kSEsNPyWTEbJnDWZ4hXl
Gyi7xP5IpzBkJiyNIbmUhjilXmAxh4jEMNJN1NuNplGk+GZDXhzt0dgLFiALFEl3
gpzQ6VGwcC/B1ZxoFUI8T1JLyPg+H+7BP3mvWDBDNFfeTQIPVzixFfErGxbfqojH
Xq+E5nk9w5G20rOF3HntIiows1PEP8ynFk1j2KeXZIX88sPpmnFeOdV6+f8dhty9
gt5td8Y/SEqhY+BZcYzvJiTSATdvSagiHafUtCempiPEOac8rTtMJxhPF6tu9LHM
rBngcO1YexBpABGep/rQ
=2LSc
-----END PGP SIGNATURE-----

--Sig_/JWCJeSKCG.h83Ph=5oELDFc--


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---