Date: Thu, 21 Jan 2016 21:38:05 -0800
From: Isaac Dunham <ibid.ag@gmail.com>
To: Timo Teras <timo.teras@iki.fi>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH 3/3] non-free/xephem: new aport
Message-ID: <20160122053804.GB5959@newbook>
References: <1453270063-13164-1-git-send-email-ibid.ag@gmail.com>
 <1453270063-13164-3-git-send-email-ibid.ag@gmail.com>
 <20160120104449.2e3197a4@vostro>
 <20160120170610.GA2549@newbook>
 <20160121102354.5b6210fe@vostro>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160121102354.5b6210fe@vostro>
User-Agent: Mutt/1.5.24 (2015-08-30)

On Thu, Jan 21, 2016 at 10:23:54AM +0200, Timo Teras wrote:
> On Wed, 20 Jan 2016 09:06:11 -0800
> Isaac Dunham <ibid.ag@gmail.com> wrote:
> 
> > On Wed, Jan 20, 2016 at 10:44:49AM +0200, Timo Teras wrote:
> > > On Tue, 19 Jan 2016 22:07:43 -0800
> > > Isaac Dunham <ibid.ag@gmail.com> wrote:
> > >   
> > > > License is "free for personal/educational/public research only,
> > > > no derivatives without permission, binaries can be distributed
> > > > only if minimal changes are made for porting only
> > > > ---
> > > >  non-free/xephem/01-use-mandoc.patch | 13 +++++++++
> > > >  non-free/xephem/APKBUILD            | 56
> > > > +++++++++++++++++++++++++++++++++++++ 2 files changed, 69
> > > > insertions(+) create mode 100644
> > > > non-free/xephem/01-use-mandoc.patch create mode 100644
> > > > non-free/xephem/APKBUILD  
> > > 
> > > This failed with:
> > > 
> > > make[1]: warning: jobserver unavailable: using -j1.  Add '+' to
> > > parent make rule. make[1]: Entering directory
> > > '/home/tteras/aports/non-free/xephem/src/xephem-3.7.7/libz' gcc
> > > -Wall -O2 -Os -fomit-frame-pointer  -c -o adler32.o adler32.c gcc
> > > -Wall -O2 -Os -fomit-frame-pointer  -c -o compress.o compress.c
> > > gcc  -Wall -O2 -Os -fomit-frame-pointer  -c -o crc32.o crc32.c gcc
> > > -Wall -O2 -Os -fomit-frame-pointer  -c -o uncompr.o uncompr.c gcc
> > > -Wall -O2 -Os -fomit-frame-pointer  -c -o deflate.o deflate.c gcc
> > > -Wall -O2 -Os -fomit-frame-pointer  -c -o trees.o trees.c gcc
> > > -Wall -O2 -Os -fomit-frame-pointer  -c -o zutil.o zutil.c gcc
> > > -Wall -O2 -Os -fomit-frame-pointer  -c -o inflate.o inflate.c gcc
> > > -Wall -O2 -Os -fomit-frame-pointer  -c -o inftrees.o inftrees.c
> > > gcc  -Wall -O2 -Os -fomit-frame-pointer  -c -o inffast.o inffast.c
> > > ar rc libz.a adler32.o compress.o crc32.o uncompr.o deflate.o
> > > trees.o zutil.o inflate.o inftrees.o inffast.o ranlib libz.a
> > > make[1]: Leaving directory
> > > '/home/tteras/aports/non-free/xephem/src/xephem-3.7.7/libz'  
> > > >>> ERROR: xephem: all failed
> > > >>> xephem: Uninstalling dependencies...  
> > > 
> > > Not sure what the exact error is. Perhaps related to parallel build
> > > too. Also there seems to be embedded standard libs like libz and
> > > libpng. Possibly others, I wonder if it could use the system libs
> > > instead?  
> > 
> > Would it be possible for you to send a full build log?
> > (I have only a single-core hyperthreading cpu)
> 
> http://dev.alpinelinux.org/~tteras/xephem-build-fail.txt

Thanks.
Parallel build issue with the way dependencies were written.

all: libs xephem xephem.1

xephem: $(OBJS) $(INCS)

will work if you have few enough threads, but it can build 'libs' in
parallel with 'xephem'.

> > As far as standard libs, here's a summary:
> > libz	standard
> > libpng	standard, but old (1.2.8 is bundled; 1.6 would need
> > source changes; should update to 1.2.5x at least)
> > libjpegd	renamed libjpeg-6b; should be easy to update
> > libXm	OpenMotif binaries; not used
> > liblilxml	not widely available; written by same author, LGPL
> > libip libastro	local libs used in build
> 
> Sounds kinda old and outdated code. Generally we try to avoid bundled
> libs; but there are few exceptions too.

Right now I'm waiting for an answer from the author about those.
(Remember, there's a reason this is in non-free/.)

For what it's worth, XEphem is one of the few programs where I wouldn't
worry too much about vulnerabilities.
You'd have a hard time opening a file without deliberately installing it;
someone who could manage to come up with an exploit would have a hundred
easier ways.

If I don't get the OK to distribute xephem built with upgraded libpng
and system libz, I will submit an aport, including the patches in the
same directory but with a note rather than including them in sources.


Thanks,
Isaac Dunham



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---