Sender: =?UTF-8?Q?Timo_Ter=C3=A4s?= <timo.teras@gmail.com>
Date: Sat, 23 Jan 2016 23:17:39 +0200
From: Timo Teras <timo.teras@iki.fi>
To: =?UTF-8?B?U8O2cmVu?= Tempel <soeren+git@soeren-tempel.net>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH] main/mpc: add bash completion
 subpackage
Message-ID: <20160123231739.6cfb577a@vostro>
In-Reply-To: <1453557412-7367-1-git-send-email-soeren+git@soeren-tempel.net>
References: <1453557412-7367-1-git-send-email-soeren+git@soeren-tempel.net>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Sat, 23 Jan 2016 14:56:52 +0100
S=C3=B6ren Tempel <soeren+git@soeren-tempel.net> wrote:

> ---
>  main/mpc/APKBUILD | 34 +++++++++++++++++++++++++++-------
>  1 file changed, 27 insertions(+), 7 deletions(-)
>=20
> diff --git a/main/mpc/APKBUILD b/main/mpc/APKBUILD
> index 13de645..e322726 100644
> --- a/main/mpc/APKBUILD
> +++ b/main/mpc/APKBUILD
> =20
>  package() {
> -	cd "$srcdir"/mpc-$pkgver
> +	cd "$_builddir"
>  	make DESTDIR=3D"$pkgdir" install || return 1
> +
> +	# Remove the bash completion file from the -doc subpackage.
> +	rm -f
> "$pkgdir"/usr/share/doc/$pkgname/$pkgname-completion.bash }
> +
> +bashcomp() {
> +	depends=3D""
> +	pkgdesc=3D"Bash completions for $pkgname"
> +	install_if=3D"$pkgname=3D$pkgver-r$pkgrel bash-completion"
> +	arch=3D"noarch"
> +
> +	install -Dm644 "$_builddir"/doc/$pkgname-completion.bash \
> +		"$subpkgdir"/usr/share/bash-completion/completions/$pkgname
> || return 1 +}
> +

Normally this is done so that the split function moves from $pkgdir
to $subpkg dir. Instead of package() removing, and split function
re-installing it.

Otherwise looks good.


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---