X-Original-To: alpine-aports@mail.alpinelinux.org
Delivered-To: alpine-aports@mail.alpinelinux.org
Received: from mail.alpinelinux.org (dallas-a1.alpinelinux.org [127.0.0.1])
	by mail.alpinelinux.org (Postfix) with ESMTP id E9A9BDC08F8
	for <alpine-aports@mail.alpinelinux.org>; Mon,  1 Feb 2016 02:10:07 +0000 (UTC)
Received: from mail-pf0-f170.google.com (mail-pf0-f170.google.com [209.85.192.170])
	(using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
	(No client certificate requested)
	by mail.alpinelinux.org (Postfix) with ESMTPS id 22077DC00AD
	for <alpine-aports@lists.alpinelinux.org>; Mon,  1 Feb 2016 02:10:06 +0000 (UTC)
Received: by mail-pf0-f170.google.com with SMTP id x125so74885785pfb.0
        for <alpine-aports@lists.alpinelinux.org>; Sun, 31 Jan 2016 18:10:06 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=date:from:to:cc:subject:message-id:mime-version:content-type
         :content-disposition:content-transfer-encoding:user-agent;
        bh=O3E32U5voN82m7cTVSLYMkzcJ2AutCcaZokmGKiypcA=;
        b=D9s4JUAbtU7+MTmZWEbmyr1xioGCkzS9W1GaNnMy+Fhg7L0vN2rJraNwgzzBN5wgzS
         ze7CLywFqfxcqYRjPJPGfBw3ZF6UknmxB/pTIqmsl/jzk6XllzqkCV6opuRhYMNqHlr7
         8/ytRfuuMT7PxrUjAGxDQMq21dvBhlB2J+M3iG/nqa1xkLM8e2ogs33cNVJuVG/p355K
         NZbl9WsBUZDT+paRALEiFifImFhBMAqZslKTo3RR5cxwrsWzXs0k1RG9I8i9KL+knRMG
         w4gxoO8y/YD7QKndbJgNhKtvyz35Z1KdJs1R8uxQ2lKAGMiYcu/yXAAbCy/TBmsbYyLF
         ukDw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version
         :content-type:content-disposition:content-transfer-encoding
         :user-agent;
        bh=O3E32U5voN82m7cTVSLYMkzcJ2AutCcaZokmGKiypcA=;
        b=gCPIlWlkbXemoGzoCUKKf338FAqWym8qr3KNjlDeZVCkF3GjEpqp6kdk7r8TjVTbLf
         QJZEXKZIFL9xXRynK56av5yYEwgJqfs5plnQzqpkje36z9HpZnfVsgrbe4UeZ8Sr1ssj
         njaD7rHYMXVz1y0hzmWkHxt2DwS658mFgGK98SjH461iiWSsNrlqYj9aLdWUMWcNNgms
         m+G4DTJ7Cr6iAXJahKO3zrbq8x4AGK8rMHwSYYFIaJq+9TANOquDUsDBsLi18k/eKJfm
         jkQpgng3GjKGnwpjGNFuJEnPin97LfChyuJwQ3MmqxWF+SlATflXXVF435MzBLa1Syrt
         1czg==
X-Gm-Message-State: AG10YORNLBGKQ7Ado8KQY29Dk3GK/fydoydsNcOJkEWSNYcvcfsr4FwT991/zpJw6AI1Qg==
X-Received: by 10.98.14.68 with SMTP id w65mr34838443pfi.146.1454292603843;
        Sun, 31 Jan 2016 18:10:03 -0800 (PST)
Received: from newbook ([50.0.225.136])
        by smtp.gmail.com with ESMTPSA id z3sm38616071par.17.2016.01.31.18.10.03
        (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Sun, 31 Jan 2016 18:10:03 -0800 (PST)
Date: Sun, 31 Jan 2016 18:09:59 -0800
From: Isaac Dunham <ibid.ag@gmail.com>
To: alpine-aports@lists.alpinelinux.org
Cc: soeren@soeren-tempel.net
Subject: [alpine-aports] Please *don't* drop prepare!
Message-ID: <20160201020958.GA4726@newbook>
X-Mailinglist: alpine-aports
Precedence: list
List-Id: Alpine Development <alpine-aports.lists.alpinelinux.org>
List-Unsubscribe: 
	<mailto:alpine-aports+unsubscribe@lists.alpinelinux.org?subject=unsubscribe>
List-Post: <mailto:alpine-aports@lists.alpinelinux.org>
List-Help: <mailto:alpine-aports+help@lists.alpinelinux.org?subject=help>
List-Subscribe: 
	<mailto:alpine-aports+subscribe@lists.alpinelinux.org?subject=subscribe>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
User-Agent: Mutt/1.5.24 (2015-08-30)
X-Virus-Scanned: ClamAV using ClamSMTP

I noticed this recent commit:
>commit 5c904717322f8113870abf48cc93c3c8b00ab4e8
>commit 68558ab72661ec5091323aca7b3ff85679220433
>Author: S=F6ren Tempel <email hidden>
>Date:   Sun Jan 31 13:30:14 2016 +0100
>
>    testing/noice: upgrade to 0.4
>
>    diff --git a/testing/noice/APKBUILD b/testing/noice/APKBUILD
>    index c2e2eed..77a7f0b 100644
>
>...
>-prepare() {
>-	local i
>-	cd "$_builddir"
>-	for i in $source; do
>-		case $i in
>-		*.patch) msg $i; patch -p1 -i "$srcdir"/$i || return 1;;
>-		esac
>-	done
>-}
>-

DON'T DO THAT!

This makes it needlessly hard to add patches: the moment someone wants to
fix a problem, this bites them because they'll try adding a patch,
build, and wonder "Why on earth am I seeing the problem I just fixed?"

I just ran into this with bridge-utils.


Anyhow...
Is there a reason that this couldn't be moved to abuild?
I know that bash uses -p0 patches, which wouldn't work with this.
But other than that, it seems to be a universal constant.

Thanks,
Isaac Dunham


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---