X-Original-To: alpine-aports@mail.alpinelinux.org
Delivered-To: alpine-aports@mail.alpinelinux.org
Received: from mail.alpinelinux.org (dallas-a1.alpinelinux.org [127.0.0.1])
	by mail.alpinelinux.org (Postfix) with ESMTP id 4D9CBDC0540
	for <alpine-aports@mail.alpinelinux.org>; Mon,  1 Feb 2016 08:21:13 +0000 (UTC)
Received: from newmail.tetrasec.net (unknown [74.117.189.116])
	by mail.alpinelinux.org (Postfix) with ESMTP id 27503DC0114
	for <alpine-aports@lists.alpinelinux.org>; Mon,  1 Feb 2016 08:21:13 +0000 (UTC)
Received: from ncopa-desktop.alpinelinux.org (103.63.200.37.customer.cdi.no [37.200.63.103])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: n@tanael.org)
	by newmail.tetrasec.net (Postfix) with ESMTPSA id 13DFE5A07C1;
	Mon,  1 Feb 2016 08:21:11 +0000 (GMT)
Date: Mon, 1 Feb 2016 09:21:07 +0100
From: Natanael Copa <ncopa@alpinelinux.org>
To: Isaac Dunham <ibid.ag@gmail.com>
Cc: alpine-aports@lists.alpinelinux.org, soeren@soeren-tempel.net
Subject: Re: [alpine-aports] Please *don't* drop prepare!
Message-ID: <20160201092107.4bb58861@ncopa-desktop.alpinelinux.org>
In-Reply-To: <20160201020958.GA4726@newbook>
References: <20160201020958.GA4726@newbook>
X-Mailer: Claws Mail 3.13.1 (GTK+ 2.24.28; x86_64-alpine-linux-musl)
X-Mailinglist: alpine-aports
Precedence: list
List-Id: Alpine Development <alpine-aports.lists.alpinelinux.org>
List-Unsubscribe: 
	<mailto:alpine-aports+unsubscribe@lists.alpinelinux.org?subject=unsubscribe>
List-Post: <mailto:alpine-aports@lists.alpinelinux.org>
List-Help: <mailto:alpine-aports+help@lists.alpinelinux.org?subject=help>
List-Subscribe: 
	<mailto:alpine-aports+subscribe@lists.alpinelinux.org?subject=subscribe>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-Virus-Scanned: ClamAV using ClamSMTP

On Sun, 31 Jan 2016 18:09:59 -0800
Isaac Dunham <ibid.ag@gmail.com> wrote:

> I noticed this recent commit:
> >commit 5c904717322f8113870abf48cc93c3c8b00ab4e8
> >commit 68558ab72661ec5091323aca7b3ff85679220433
> >Author: S=F6ren Tempel <email hidden>
> >Date:   Sun Jan 31 13:30:14 2016 +0100
> >
> >    testing/noice: upgrade to 0.4
> >
> >    diff --git a/testing/noice/APKBUILD b/testing/noice/APKBUILD
> >    index c2e2eed..77a7f0b 100644
> >
> >...
> >-prepare() {
> >-	local i
> >-	cd "$_builddir"
> >-	for i in $source; do
> >-		case $i in
> >-		*.patch) msg $i; patch -p1 -i "$srcdir"/$i || return 1;;
> >-		esac
> >-	done
> >-}
> >- =20
>=20
> DON'T DO THAT!
>=20
> This makes it needlessly hard to add patches: the moment someone wants to
> fix a problem, this bites them because they'll try adding a patch,
> build, and wonder "Why on earth am I seeing the problem I just fixed?"
>=20
> I just ran into this with bridge-utils.

+1
=20
> Anyhow...
> Is there a reason that this couldn't be moved to abuild?

Not really.

> I know that bash uses -p0 patches, which wouldn't work with this.
> But other than that, it seems to be a universal constant.

I think gentoo tries various -pN variants before error. We could do somethi=
ng like:

patch -p1 -i .... || patch -p0 -i ...



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---