Date: Mon, 1 Feb 2016 22:29:08 +0100
From: =?iso-8859-1?Q?S=F6ren?= Tempel <soeren@soeren-tempel.net>
To: alpine-aports@lists.alpinelinux.org
Cc: ncopa@alpinelinux.org
Subject: Re: [alpine-aports] Please *don't* drop prepare!
Message-ID: <20160201212908.GA19972@francium.lan>
References: <20160201020958.GA4726@newbook>
 <20160201092107.4bb58861@ncopa-desktop.alpinelinux.org>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20160201092107.4bb58861@ncopa-desktop.alpinelinux.org>
User-Agent: Mutt/1.5.24 (2015-08-30)

On 01.02.16, Natanael Copa wrote:
> > This makes it needlessly hard to add patches: the moment someone wants =
to
> > fix a problem, this bites them because they'll try adding a patch,
> > build, and wonder "Why on earth am I seeing the problem I just fixed?"
> >=20
> > I just ran into this with bridge-utils.
>=20
> +1

I just assumed that noice was simple enough to probably never need
patches in the future, however, if it's considered a "common practice"
to always keep the prepare function than I will do so in the future.

> =20
> > Anyhow...
> > Is there a reason that this couldn't be moved to abuild?
>=20
> Not really.

I would also prefer it if all source files matching "*.patch" would be
applied automatically.

> > I know that bash uses -p0 patches, which wouldn't work with this.
> > But other than that, it seems to be a universal constant.
>=20
> I think gentoo tries various -pN variants before error. We could do somet=
hing like:
>=20
> patch -p1 -i .... || patch -p0 -i ...

That can cause a lot of problems. I think the easier solution would be
to simply add an optional variable (with the default value "-p1") which
allows you to pass extra command line flags to patch(1) from the
APKBUILD itself.

S=F6ren.


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---