Date: Tue, 4 Jun 2019 23:39:23 +0200
From: Milan =?utf-8?Q?P=2E_Stani=C4=87?= <mps@arvanta.net>
To: Marian Buschsieweke <marian.buschsieweke@ovgu.de>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH 5/6] testing/pulseview: New aport
Message-ID: <20190604213923.GA5264@arya.arvanta.net>
References: <20190404165559.6565-1-marian.buschsieweke@ovgu.de>
 <20190404165559.6565-5-marian.buschsieweke@ovgu.de>
 <20190601123540.GA16853@arya.arvanta.net>
 <20190603211518.39fd3542@faultier2go>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190603211518.39fd3542@faultier2go>
User-Agent: Mutt/1.12.0 (2019-05-25)

Hi,

On Mon, 2019-06-03 at 21:15, Marian Buschsieweke wrote:
> Hi,
> 
> thanks for pointing out that issue. I missed that doxygen is required to
> generate the C++ bindings for libsigrok. I added a patch to fix that.

Applied patch with reverting deletion of the 'cd $builddir'.
Today we discussed this and concluded that is 'best practice' is to keep
'cd $builddir' till the main repository become ready for this change.
Although this is not a bug (remove/don't use 'cd $builddir') for now I
decided to keep it if there are no strong reasons for removal.

Sorry for misleading you.

> I also
> updated the patch for pulseview to no longer contain unneeded "${}" and also no
> "cd $builddir".

Applied.

n.b. Please send patches to alpine-aports@lists.alpinelinux.org
(patchwork.alpinelinux.org) where more people can review, help and
apply.

Thank you for helping Alpine.

-- 
Best regards

> Kind regards,
> Marian
...


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---