Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Tue, 05 May 2015 15:24:28 +0100
From: IT Offshore Developer <developer@it-offshore.co.uk>
To: Natanael Copa <ncopa@alpinelinux.org>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH 3/3] testing/udevil: new aport
Organization: IT Offshore
Reply-To: developer@it-offshore.co.uk
Mail-Reply-To: developer@it-offshore.co.uk
In-Reply-To: <20150505145055.2dcecc77@ncopa-desktop.alpinelinux.org>
References: <1430785588-65737-1-git-send-email-developer@it-offshore.co.uk>
 <1430785588-65737-3-git-send-email-developer@it-offshore.co.uk>
 <20150505145055.2dcecc77@ncopa-desktop.alpinelinux.org>
Message-ID: <508dcde11413c741901dcaa83476ea9f@it-offshore.co.uk>
User-Agent: Roundcube Webmail/1.0.5

ncopa - I will revise udevil - I agree 
/usr/share/apk-tools/$pkgname/post-install-message is a better place to 
store non colored messages - the formatting is best left to apk-tools to 
save space.

Stuart.

On 2015-05-05 13:50, Natanael Copa wrote:
> On Tue,  5 May 2015 00:26:28 +0000
> Stuart Cardall <developer@it-offshore.co.uk> wrote:
> 
>> +++ b/testing/udevil/udevil.post-install
>> @@ -0,0 +1,22 @@
>> +#!/bin/sh
>> +
>> +NORMAL="\033[1;0m"
>> +STRONG="\033[1;1m"
>> +GREEN="\033[1;32m"
>> +
>> +print_strong() {
>> +        local prompt="${STRONG}$1 ${GREEN}$2${NORMAL}"
>> +        printf "${prompt} %s\n"
>> +}
>> +
>> +print_strong "\nTo mount / unmount devices without the root 
>> password:" " add your user account to the 'plugdev' group."
>> +print_strong "\nOptional dependencies:"
>> +print_strong "\nzenity: " "	(devmon popups)"
>> +print_strong "davfs2: " "	(mount WebDAV resources)"
>> +print_strong "cifs-utils: " "	(mounting samba shares)"
>> +print_strong "curlftpfs: " "	(mounting ftp shares)"
>> +print_strong "nfs-utils: " "	(mounting nfs shares)"
>> +print_strong "sshfs-fuse: " "	(mounting sftp shares)"
>> +print_strong "eject: " "	(eject via devmon)"
>> +exit 0
>> +
> 
> I am not sure I like the post-install script.
> 
> - There is no guarantee that there are color support. (think: apk add
>   $packages > logfile)
> 
> - There is no guarantee user reach to read it. package might be
>   installed together with 100 other packages.
> 
> - It is meaningless to show this message every reboot. (tmpfs install)
> 
> - If every package did something like this it would slow down the
>   install.
> 
> 
> Can we remove the post-install and create a doc on the wiki instead?
> 
> If we want this kind of informative messages for installed packages,
> then we should consider add this as a feature for apk-tools or similar.
> 
> The message should be displayed after install (maybe via trigger?) and
> maybe we want be able to read the message long time after package was
> installed.
> 
> Maybe store them as /usr/share/apk-tools/$pkgname/post-install-message
> or similar.
> 
> In any case, I don't like doing it from post-install.
> 
> -nc


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---