X-Original-To: alpine-aports@mail.alpinelinux.org Delivered-To: alpine-aports@mail.alpinelinux.org Received: from mail.alpinelinux.org (dallas-a1.alpinelinux.org [127.0.0.1]) by mail.alpinelinux.org (Postfix) with ESMTP id 63D1CDC132A for ; Wed, 10 Feb 2016 11:56:54 +0000 (UTC) Received: from forward15p.cmail.yandex.net (forward15p.cmail.yandex.net [87.250.241.141]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.alpinelinux.org (Postfix) with ESMTPS id 193D5DC087F for ; Wed, 10 Feb 2016 11:56:52 +0000 (UTC) Received: from smtp17.mail.yandex.net (smtp17.mail.yandex.net [IPv6:2a02:6b8:0:1402::118]) by forward15p.cmail.yandex.net (Yandex) with ESMTP id 6C5B4207AC; Wed, 10 Feb 2016 14:56:50 +0300 (MSK) Received: from smtp17.mail.yandex.net (localhost [127.0.0.1]) by smtp17.mail.yandex.net (Yandex) with ESMTP id 09D5A190182B; Wed, 10 Feb 2016 14:56:49 +0300 (MSK) Received: by smtp17.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id TX5CscesWj-ulSudJkW; Wed, 10 Feb 2016 14:56:48 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1455105409; bh=GvggPsyycdPFkz4GGch4hi+pliB6lr7RTwr2hRzePj4=; h=Subject:To:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=U2GiKjCT6QmhpTGtX+4VgxjAODyECPvmrE9kyh4lwGNbM6CqWrMRvGSrnKc4xw160 ht4rJw0SJuZfV1LI4DufPqEUTSJWk7dXEAPDCw0Ji2SWe1YJHBIJaWkxU0dw6ACFsM HHgOgJhbhle4Fomb5kEA5Z6sk5hW5eEF/OFAh52k= Authentication-Results: smtp17.mail.yandex.net; dkim=pass header.i=@yandex.ru X-Yandex-ForeignMX: US X-Yandex-Suid-Status: 1 0,1 0 Subject: Re: [alpine-aports] [PATCH] testing/at: new aport To: Leonardo Arena , alpine-aports@lists.alpinelinux.org References: <1454582321-3254-1-git-send-email-msun00@yandex.ru> <1455014656.29660.9.camel@df1844j> From: Alexander Belkov Message-ID: <56BB257A.5090404@yandex.ru> Date: Wed, 10 Feb 2016 21:56:42 +1000 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 In-Reply-To: <1455014656.29660.9.camel@df1844j> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP Sorry to bother you directly, but I seem to have made the alpine-aports mailing list a bit messy :/ Mea culpa: I didn't check in time that 'at' aport has already been accepted, sent patches for both of my local commits and annotated them as "new aport". I don't feel it's right to address the committer (Nataniel Copa) since you first noted my package request (#5030) and gave me some useful hints. Please accept my most recent patch for the 'at' (http://lists.alpinelinux.org/alpine-aports/2385.html) with an annotation of your own - if I try to do it myself, I'm at risk to accidentally DOS the mailing list... Not planning to bother you more right now :) Thank you so much and glorious prospectives to you! Alexander Belkov On 09.02.2016 20:44, Leonardo Arena wrote: > Thank you! > Could you please see comments below? The first comment address something > to be fixed. The other are just cosmetic bugs. > > On gio, 2016-02-04 at 10:38 +0000, Alexander Belkov wrote: > $install files should not go into $source By convention we use > "command" which points to full path binary. Also, OpenRC has built-in > "$SVCNAME" which is the basename of the init script. > There are typos in "ebegin" lines. > > Thanks! > > - leo --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---