X-Original-To: alpine-aports@mail.alpinelinux.org Delivered-To: alpine-aports@mail.alpinelinux.org Received: from mail.alpinelinux.org (dallas-a1.alpinelinux.org [127.0.0.1]) by mail.alpinelinux.org (Postfix) with ESMTP id 59494DC08F7 for ; Fri, 3 Jul 2015 15:16:39 +0000 (UTC) Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mail.alpinelinux.org (Postfix) with ESMTPS id D8188DC0222 for ; Fri, 3 Jul 2015 15:16:37 +0000 (UTC) Received: by widjy10 with SMTP id jy10so112537467wid.1 for ; Fri, 03 Jul 2015 08:16:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=T3EoZyd9eE4M9hDfXGPTSkkoRkIcoQunITbe9Siz0OQ=; b=j9eebDjIOfPBtV2vkXvhdLYavZT/mxMrNTe+GiTBNAdzZt7m+uUIcEIy88ubXEcyg7 Qp/GMtqPx+NxDJPmqxkiux/cylEgZoycmhlb5ExWddVOj7H/HSQu505sto/UBJvq5fZS 5uLCLs2Y5nG7qvgOkj700MZPqpbihdGONxG0UTh2fMa6q3+ef7yaaPkV/VF2Pp8nNPS+ fwfWGpPsj5eTj/EbVTB9TPWB5LzS1EpTemnr6lNNxee+I/SC4kT9mmB5WhZJVOdhdrAf p0Z6AqKf7Lbe9rmCMqGegzKcID0Fdzp39bhe8Psw8EjXifJAnwcyW7V8BZIuxBTu/3BK Lahg== X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 X-Received: by 10.180.215.101 with SMTP id oh5mr28313253wic.6.1435936596280; Fri, 03 Jul 2015 08:16:36 -0700 (PDT) Received: by 10.28.211.199 with HTTP; Fri, 3 Jul 2015 08:16:36 -0700 (PDT) In-Reply-To: <1435789648-2762-1-git-send-email-apatrushev@gmail.com> References: <1435789648-2762-1-git-send-email-apatrushev@gmail.com> Date: Fri, 3 Jul 2015 17:16:36 +0200 Message-ID: Subject: Re: [alpine-aports] [PATCH] testing/pbzip2: new aport From: Carlo Landmeter To: Anton Patrushev Cc: alpine-aports@lists.alpinelinux.org Content-Type: multipart/alternative; boundary=001a1135f952bdca790519fa0a0b X-Virus-Scanned: ClamAV using ClamSMTP --001a1135f952bdca790519fa0a0b Content-Type: text/plain; charset=UTF-8 Thanks but not committed yet, some comments below. On 2 July 2015 at 00:27, Anton Patrushev wrote: > http://compression.ca/pbzip2/ > PBZIP2 is a parallel implementation of the bzip2 block-sorting file > compressor. > --- > testing/pbzip2/APKBUILD | 31 +++++++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > create mode 100644 testing/pbzip2/APKBUILD > > diff --git a/testing/pbzip2/APKBUILD b/testing/pbzip2/APKBUILD > new file mode 100644 > index 0000000..26b5870 > --- /dev/null > +++ b/testing/pbzip2/APKBUILD > @@ -0,0 +1,31 @@ > +# Contributor: Anton Patrushev > +# Maintainer: > +pkgname=pbzip2 > +pkgver=1.1 > +pkgrel=12 > pkgrel should always start at 0. We use it to generate a new package when version didn't change (ie patches). pkgver should be set to 1.1.12 which is the actual version. > +pkgdesc="pbzip2 is a parallel implementation of the bzip2 block-sorting > file compressor." > +url="http://compression.ca/pbzip2/" > +arch="all" > +license="BSD" > +depends="bzip2" > Why does this depends on bzip2? > +makedepends="bzip2-dev" > +subpackages="" > +source=" > https://launchpad.net/pbzip2/$pkgver/$pkgver.$pkgrel/+download/pbzip2-$pkgver.$pkgrel.tar.gz > " > please update src accordingly > + > +_builddir="$srcdir"/$pkgname-$pkgver.$pkgrel > +prepare() { > + local i > I guess this is a leftover? > + cd "$_builddir" > + make || return 1 > make should be run in build() function. > +} > + > +build() { > + cd "$_builddir" > +} > + > +package() { > + cd "$_builddir" > + make PREFIX="$pkgdir"/usr install || return 1 > +} > +md5sums="91a4911b13305850423840eb0fa6f4f9 pbzip2-1.1.12.tar.gz" > + > -- > 2.4.5 > > > > --- > Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org > Help: alpine-aports+help@lists.alpinelinux.org > --- > > --001a1135f952bdca790519fa0a0b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Than= ks but not committed yet, some comments below.

On 2 July 2015 at 00:27, Anton Pat= rushev <apatrushev@gmail.com> wrote:
http://compression.ca/pbzip2/
PBZIP2 is a parallel implementation of the bzip2 block-sorting file compres= sor.
---
=C2=A0testing/pbzip2/APKBUILD | 31 +++++++++++++++++++++++++++++++
=C2=A01 file changed, 31 insertions(+)
=C2=A0create mode 100644 testing/pbzip2/APKBUILD

diff --git a/testing/pbzip2/APKBUILD b/testing/pbzip2/APKBUILD
new file mode 100644
index 0000000..26b5870
--- /dev/null
+++ b/testing/pbzip2/APKBUILD
@@ -0,0 +1,31 @@
+# Contributor: Anton Patrushev <apatrushev@gmail.com>
+# Maintainer:
+pkgname=3Dpbzip2
+pkgver=3D1.1
+pkgrel=3D12

pkgrel should always start= at 0. We use it to generate a new package when version didn't change (= ie patches).
pkgver should be set to 1.1.12 which is the actual v= ersion.
=C2=A0
+pkgdesc=3D"pbzip2 is a parallel implementation of the bzip2 block-sor= ting file compressor."
+url=3D"http://compression.ca/pbzip2/"
+arch=3D"all"
+license=3D"BSD"
+depends=3D"bzip2"

Why does t= his depends on bzip2?
=C2=A0
+makedepends=3D"bzip2-dev"
+subpackages=3D""
+source=3D"https://launchpad.net/pbzip2/$pkgver/$pkgver.$pkgrel/+download/pbzi= p2-$pkgver.$pkgrel.tar.gz"

ple= ase update src accordingly
=C2=A0
+
+_builddir=3D"$srcdir"/$pkgname-$pkgver.$pkgrel
+prepare() {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0local i

I g= uess this is a leftover?
=C2=A0
+=C2=A0 =C2=A0 =C2=A0 =C2=A0cd "$_builddir"
+=C2=A0 =C2=A0 =C2=A0 =C2=A0make || return 1

make should be run in build() function.
=C2=A0
+}
+
+build() {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0cd "$_builddir"
+}
+
+package() {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0cd "$_builddir"
+=C2=A0 =C2=A0 =C2=A0 =C2=A0make PREFIX=3D"$pkgdir"/usr install |= | return 1
+}
+md5sums=3D"91a4911b13305850423840eb0fa6f4f9=C2=A0 pbzip2-1.1.12.tar.g= z"
+
--
2.4.5



---
Unsubscribe:=C2=A0 alpine-aports+unsubscribe@lists.alpinelinux.org
Help:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0alpine-aports+help@lists.alpinelinux.org
---


--001a1135f952bdca790519fa0a0b-- --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---