X-Original-To: alpine-aports@lists.alpinelinux.org Received: from mail-ua1-f46.google.com (mail-ua1-f46.google.com [209.85.222.46]) by lists.alpinelinux.org (Postfix) with ESMTP id 9AC2FF8558F for ; Mon, 31 Dec 2018 11:18:09 +0000 (UTC) Received: by mail-ua1-f46.google.com with SMTP id p9so8564762uaa.5 for ; Mon, 31 Dec 2018 03:18:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YIISt/O7Ykuw1AhEKLJkjdCDLxAzVuoIsy+HGfRi48Y=; b=vIAI9nph53vsF6ojvyoZ+rm4TlxJlMVmbkEHdRDut2NmH3T2q/hQOxevaLENM11Jy+ psaE5dVsbDVN/mASRO7cOLmhkvqiQhG7oHcZhtSdQEa8sHkv9RJ/5/b7jG0+/l6iYAgk Da4hrIbnXDc9UWTN2l7BC0gL9B3BM/1srHmsTdNRp/LJPsXD+lF2jLtdJ1VJBpwH5cgw IdomGrHplhZYMXy6blc6Pha0s9CFvRMBWMKuhd7MFVC1LwDvSIQEPvKSC8nrQASkrVJP fHi7s2M+gCpiCic/361IiCM98j7ktwe8mEBsq0KzEURhfoFyU5ARyY4UFk4X46/aHCMm G8Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YIISt/O7Ykuw1AhEKLJkjdCDLxAzVuoIsy+HGfRi48Y=; b=EfFxIlwZnw5zby4eMiU+wSv6k1zIxyCeOKRPv68qEAfwnWi76CGdRE0tldfaVCZ/9d a3KrlN/PnieiH2fS3cIEZUWcoxqD4zEmvtKwiC3xHHlTJBD+z4pY+FtR2uaE+bcBsd8s aTSmrdFCKt+jliogJNSap14TZ3dlYSTjjAGz1+QuXTZEoEMLryN+xsa2sMq40dABGPvP bH41ywAVAbfhzRemG2EzIfCpkM0chMtawoXYHSAsCUBO+2FOJSow0pP73rumHiMsEfhR FJ8uhSUx5BYgpcOm+028YrOESqn9lZ8nNqH/snPVcK9S9vv/PkWcDnOMJuR1LOLEoQOH +Kog== X-Gm-Message-State: AJcUukdth9LqqT6JRC+3VlwMdlTOUMyrYHH2NbGdPc9Si05rOZf98vfA o6aQdEwHVT8Pt2uEYHEpwrfxZ4UrURZV0TdwvXRnE7Ar/uk= X-Google-Smtp-Source: ALg8bN7LdEBNU+qTUuPI/TmYfJL2pdVyVRi28XnrzWgAH1HDjUuiEe8ChQm4yNHAn/yGsEBMHZCJIJ4MQMQwxRtt6kw= X-Received: by 2002:ab0:2385:: with SMTP id b5mr13218230uan.73.1546255088916; Mon, 31 Dec 2018 03:18:08 -0800 (PST) X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 References: <20181230111722.21006-1-martin.rusko@gmail.com> In-Reply-To: <20181230111722.21006-1-martin.rusko@gmail.com> From: Leonardo Arena Date: Mon, 31 Dec 2018 12:17:58 +0100 Message-ID: Subject: Re: [alpine-aports] [PATCH] testing/minidyndns: new aport To: Martin Rusko Cc: alpine-aports Content-Type: multipart/alternative; boundary="0000000000004e9c3f057e4f9162" --0000000000004e9c3f057e4f9162 Content-Type: text/plain; charset="UTF-8" Hi, thank you for the contribution. Please see some comments below. On Sun, Dec 30, 2018 at 12:17 PM Martin Rusko wrote: > https://github.com/arkanis/minidyndns > A simple no fuss DNS server with built-in HTTP/HTTPS interface to update > IPs > --- > testing/minidyndns/APKBUILD | 55 +++++++++++++++++++ > .../minidyndns-openrc.pre-deinstall | 6 ++ > testing/minidyndns/minidyndns.confd | 5 ++ > testing/minidyndns/minidyndns.initd | 31 +++++++++++ > 4 files changed, 97 insertions(+) > create mode 100644 testing/minidyndns/APKBUILD > create mode 100644 testing/minidyndns/minidyndns-openrc.pre-deinstall > create mode 100644 testing/minidyndns/minidyndns.confd > create mode 100644 testing/minidyndns/minidyndns.initd > > diff --git a/testing/minidyndns/APKBUILD b/testing/minidyndns/APKBUILD > new file mode 100644 > index 0000000000..ccb1d974e1 > --- /dev/null > +++ b/testing/minidyndns/APKBUILD > @@ -0,0 +1,55 @@ > +# Contributor: Martin Rusko > +# Maintainer: Martin Rusko > +pkgname=minidyndns > +pkgver=1.1.4 > +pkgrel=0 > +pkgdesc="A simple no fuss DNS server with built-in HTTP/HTTPS interface > to update IPs" > +url="https://github.com/arkanis/minidyndns" > +arch="noarch" > +license="MIT" > +depends="ruby ruby-etc" > +makedepends="" > +install="$pkgname-openrc.pre-deinstall" > +subpackages="$pkgname-doc $pkgname-openrc" > +source="minidyndns-$pkgver.tar.gz:: > https://github.com/arkanis/minidyndns/archive/v$pkgver.tar.gz" > +builddir="$srcdir/$pkgname-$pkgver" > + > +build() { > + cd "$builddir" > +} > + > +check() { > + cd "$builddir" > +} > + > Since check() does effectly nothing here you should add "options=!check" and perhaps adding a comment next to it there is no test suite. > +package() { > + cd "$builddir" > + > + install -Dm755 "$srcdir"/../minidyndns.initd \ > + "$pkgdir"/etc/init.d/minidyndns > + install -Dm644 "$srcdir"/../minidyndns.confd \ > + "$pkgdir"/etc/conf.d/minidyndns > + > + install -Dm755 "$builddir"/dns.rb \ > + "$pkgdir"/usr/share/minidyndns/dns.rb > + > + install -Dm644 "$builddir"/config.example.yml \ > + "$pkgdir"/etc/minidyndns_config.yml > + > + install -d -o nobody -g nogroup "$pkgdir"/var/log/minidyndns > + > + install -d -o nobody -g nogroup "$pkgdir"/var/lib/minidyndns > + install -Dm640 -o nobody -g nogroup "$builddir"/db.example.yml \ > + "$pkgdir"/var/lib/minidyndns/db.yml > + > + install -Dm644 "$builddir"/config.example.yml \ > + > "$pkgdir"/usr/share/doc/minidyndns/config.example.yml > + > + install -Dm644 "$builddir"/db.example.yml \ > + "$pkgdir"/usr/share/doc/minidyndns/db.example.yml > + > + install -Dm644 "$builddir"/README.md \ > + "$pkgdir"/usr/share/doc/minidyndns/README.md > +} > + > +sha512sums="523e53e1a937b4d3f36eb1666444fd9024b6c059c6b145be5d725670c24fc3b339cc75eae6dde61f62c09cb195805202440df84599d197d117f0cb575d6d4f6b > minidyndns-1.1.4.tar.gz" > diff --git a/testing/minidyndns/minidyndns-openrc.pre-deinstall > b/testing/minidyndns/minidyndns-openrc.pre-deinstall > new file mode 100644 > index 0000000000..712bc37943 > --- /dev/null > +++ b/testing/minidyndns/minidyndns-openrc.pre-deinstall > @@ -0,0 +1,6 @@ > +#!/bin/sh > + > +rc-service --ifexists minidyndns stop > +rc-update --all del minidyndns > + > +exit 0 > I saw your email on alpine-devel. So far there is no package trying to stop the daemon before uninstalling and I think we would like to keep it that way. We don't try to be smart in our packages like other distros. We prefer to keep things simple and we assume that the administrator knows what he is doing. :) > diff --git a/testing/minidyndns/minidyndns.confd > b/testing/minidyndns/minidyndns.confd > new file mode 100644 > index 0000000000..3cf5d10be2 > --- /dev/null > +++ b/testing/minidyndns/minidyndns.confd > @@ -0,0 +1,5 @@ > +# > +# Specify daemon options here. > +# > + > +minidyndns_opts="--config /etc/minidyndns_config.yml --db > /var/lib/minidyndns/db.yml" > Since these are default values, may be you can add those to the init script itself and leave the conf file for customizations. : ${minidyndns_opts:="--config /etc/minidyndns_config.yml --db /var/lib/minidyndns/db.yml"} Thanks! /eo --0000000000004e9c3f057e4f9162 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

thank you for the contri= bution. Please see some comments below.

On Sun, Dec 30, 2018 at 12:17 PM Martin Rusko <martin.rusko@gmail.com> wrote= :
ht= tps://github.com/arkanis/minidyndns
A simple no fuss DNS server with built-in HTTP/HTTPS interface to update IP= s
---
=C2=A0testing/minidyndns/APKBUILD=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0| 55 +++++++++++++++++++
=C2=A0.../minidyndns-openrc.pre-deinstall=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0|=C2=A0 6 ++
=C2=A0testing/minidyndns/minidyndns.confd=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0|=C2=A0 5 ++
=C2=A0testing/minidyndns/minidyndns.initd=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0| 31 +++++++++++
=C2=A04 files changed, 97 insertions(+)
=C2=A0create mode 100644 testing/minidyndns/APKBUILD
=C2=A0create mode 100644 testing/minidyndns/minidyndns-openrc.pre-deinstall=
=C2=A0create mode 100644 testing/minidyndns/minidyndns.confd
=C2=A0create mode 100644 testing/minidyndns/minidyndns.initd

diff --git a/testing/minidyndns/APKBUILD b/testing/minidyndns/APKBUILD
new file mode 100644
index 0000000000..ccb1d974e1
--- /dev/null
+++ b/testing/minidyndns/APKBUILD
@@ -0,0 +1,55 @@
+# Contributor: Martin Rusko <martin.rusko@gmail.com>
+# Maintainer: Martin Rusko <martin.rusko@gmail.com>
+pkgname=3Dminidyndns
+pkgver=3D1.1.4
+pkgrel=3D0
+pkgdesc=3D"A simple no fuss DNS server with built-in HTTP/HTTPS inter= face to update IPs"
+url=3D"https://github.com/arkanis/minidyndns" +arch=3D"noarch"
+license=3D"MIT"
+depends=3D"ruby ruby-etc"
+makedepends=3D""
+install=3D"$pkgname-openrc.pre-deinstall"
+subpackages=3D"$pkgname-doc $pkgname-openrc"
+source=3D"minidyndns-$pkgver.tar.gz::https://github.com/arkanis/minidyndns/archive/v$pkgver.tar.gz"=
+builddir=3D"$srcdir/$pkgname-$pkgver"
+
+build() {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0cd "$builddir"
+}
+
+check() {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0cd "$builddir"
+}
+


Since check() does eff= ectly nothing here you should add "options=3D!check" and perhaps = adding a comment next to it there is no test suite.

=C2=A0
+package() {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0cd "$builddir"
+
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 install -Dm755 "$srcdir"/../minidynd= ns.initd \
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "$pkgdir"= ;/etc/init.d/minidyndns
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 install -Dm644 "$srcdir"/../minidynd= ns.confd \
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "$pkgdir"= ;/etc/conf.d/minidyndns
+=C2=A0 =C2=A0 =C2=A0 =C2=A0
+=C2=A0 =C2=A0 =C2=A0 =C2=A0install -Dm755 "$builddir"/dns.rb \ +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"$pkgdir"= /usr/share/minidyndns/dns.rb
+
+=C2=A0 =C2=A0 =C2=A0 =C2=A0install -Dm644 "$builddir"/config.exa= mple.yml \
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"$pkgdir"= /etc/minidyndns_config.yml
+
+=C2=A0 =C2=A0 =C2=A0 =C2=A0install -d -o nobody -g nogroup "$pkgdir&q= uot;/var/log/minidyndns
+
+=C2=A0 =C2=A0 =C2=A0 =C2=A0install -d -o nobody -g nogroup "$pkgdir&q= uot;/var/lib/minidyndns
+=C2=A0 =C2=A0 =C2=A0 =C2=A0install -Dm640 -o nobody -g nogroup "$buil= ddir"/db.example.yml \
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"$pkgdir"= /var/lib/minidyndns/db.yml
+
+=C2=A0 =C2=A0 =C2=A0 =C2=A0install -Dm644 "$builddir"/config.exa= mple.yml \
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0"$pkgdir"/usr/share/doc/minidyndns/config.example.yml +
+=C2=A0 =C2=A0 =C2=A0 =C2=A0install -Dm644 "$builddir"/db.example= .yml \
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0"$pkgdir"/usr/share/doc/minidyndns/db.example.yml
+
+=C2=A0 =C2=A0 =C2=A0 =C2=A0install -Dm644 "$builddir"/README.md = \
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0"$pkgdir"/usr/share/doc/minidyndns/README.md
+}
+
+sha512sums=3D"523e53e1a937b4d3f36eb1666444fd9024b6c059c6b145be5d72567= 0c24fc3b339cc75eae6dde61f62c09cb195805202440df84599d197d117f0cb575d6d4f6b= =C2=A0 minidyndns-1.1.4.tar.gz"
diff --git a/testing/minidyndns/minidyndns-openrc.pre-deinstall b/testing/m= inidyndns/minidyndns-openrc.pre-deinstall
new file mode 100644
index 0000000000..712bc37943
--- /dev/null
+++ b/testing/minidyndns/minidyndns-openrc.pre-deinstall
@@ -0,0 +1,6 @@
+#!/bin/sh
+
+rc-service --ifexists minidyndns stop
+rc-update --all del minidyndns
+
+exit 0


I saw your email on alpine-= devel. So far there is no package trying to stop the daemon before uninstal= ling and I think we would like to keep it that way.
We don't = try to be smart in our packages like other distros. We prefer to keep thing= s simple and we assume that the administrator knows what he is doing. :)

=C2=A0
diff --git a/testing/minidyndns/minidyndns.confd b= /testing/minidyndns/minidyndns.confd
new file mode 100644
index 0000000000..3cf5d10be2
--- /dev/null
+++ b/testing/minidyndns/minidyndns.confd
@@ -0,0 +1,5 @@
+#
+# Specify daemon options here.
+#
+
+minidyndns_opts=3D"--config /etc/minidyndns_config.yml --db /var/lib/= minidyndns/db.yml"


= Since these are default values, may be you can add those to the init script= itself and leave the conf file for customizations.

: ${minidyndns_opts:=3D"--config /etc/minidyndns_config.yml --db /va= r/lib/minidyndns/db.yml"}


=C2= =A0Thanks!

/eo
--0000000000004e9c3f057e4f9162-- --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---