X-Original-To: alpine-aports@mail.alpinelinux.org Delivered-To: alpine-aports@mail.alpinelinux.org Received: from mail.alpinelinux.org (dallas-a1.alpinelinux.org [127.0.0.1]) by mail.alpinelinux.org (Postfix) with ESMTP id 1D190DCA34C for ; Thu, 1 Oct 2015 12:19:21 +0000 (UTC) Received: from mail-lb0-f171.google.com (mail-lb0-f171.google.com [209.85.217.171]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mail.alpinelinux.org (Postfix) with ESMTPS id 70D28DC8739 for ; Thu, 1 Oct 2015 12:19:20 +0000 (UTC) Received: by lbwr8 with SMTP id r8so8020280lbw.2 for ; Thu, 01 Oct 2015 05:19:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=3s1+zQIz1dMLd8oltuwNPYa/HM4KASNzhthbVrFx2Z8=; b=WxaK59GtTwWl+syWobDQa3s/FDnX+qWOKVfvb4TWjIjnD5G2q13pu2G2I4T62lspFM XTbES0w6+xdBp9pMNk6EJrWwPy/8zSkUvq9YxoT7GRdBgg4vwVMhnuIl2IF0awMsJ+Tc JnjNCYYFoLMvMI3VAMr3M0b3NYW9OcZM+iWbuG1Fdilt/rESOT5QQh+begXZ7ZxrlvMw hjMdzkAf+8aNcEx8Yz3vqdrEI33Iw1GcDBa3w+O0EkiNx0jPZCHaP9p2qJ2XMnTg+P2v 5/ZMoaBezet9RP4Srwm4as7b5Dr49fSWvuPW9f5yFKFgrWJv+9SCKAphW3P4QCpXqS4Q 9kKw== X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 X-Received: by 10.25.82.10 with SMTP id g10mr1886400lfb.56.1443701957252; Thu, 01 Oct 2015 05:19:17 -0700 (PDT) Received: by 10.25.155.138 with HTTP; Thu, 1 Oct 2015 05:19:17 -0700 (PDT) In-Reply-To: <20150930144006.3947aa18@ncopa-desktop.alpinelinux.org> References: <1443487903-19624-1-git-send-email-marlus.saraiva@gmail.com> <20150930144006.3947aa18@ncopa-desktop.alpinelinux.org> Date: Thu, 1 Oct 2015 09:19:17 -0300 Message-ID: Subject: Re: [alpine-aports] [PATCH] main/erlang: Update to 18.1 From: Marlus Saraiva To: Natanael Copa Cc: alpine-aports@lists.alpinelinux.org Content-Type: multipart/alternative; boundary=001a114189b052db8d05210a0e4e X-Virus-Scanned: ClamAV using ClamSMTP --001a114189b052db8d05210a0e4e Content-Type: text/plain; charset=UTF-8 2015-09-30 9:40 GMT-03:00 Natanael Copa : > On Tue, 29 Sep 2015 00:51:43 +0000 > Marlus Saraiva wrote: > > > --- > > .../0006-Do-not-install-erlang-sources.patch | 531 > +++++++++++++++------ > > main/erlang/APKBUILD | 26 +- > > 2 files changed, 382 insertions(+), 175 deletions(-) > > > > diff --git a/main/erlang/0006-Do-not-install-erlang-sources.patch > b/main/erlang/0006-Do-not-install-erlang-sources.patch > > index 8d14da5..9b7f421 100644 > > --- a/main/erlang/0006-Do-not-install-erlang-sources.patch > > +++ b/main/erlang/0006-Do-not-install-erlang-sources.patch > > @@ -1,14 +1,5 @@ > > -From: Hans Ulrich Niedermann > > -Date: Mon, 21 Mar 2011 15:41:49 +0100 > > -Subject: [PATCH] Do not install erlang sources > > - > > -Don't install *.erl, *.xrl, *.yrl, and *.asn1 files at all. > > - > > -Signed-off-by: Peter Lemenkov > > -Signed-off-by: Hans Ulrich Niedermann > > - > > ... > > > +--- /dev/null > > ++++ otp_src_18.1-fixed/lib/ssh/src/Makefile.orig > > I suppose adding Makefile.orig was not intentional? > > Sorry about that :) > I also get a build failure: > CC obj/x86_64-alpine-linux-musl/opt/smp/hipe_x86_signal.o > hipe/hipe_x86_signal.c:233:0: warning: "_NSIG" redefined > #define _NSIG NSIG > ^ > In file included from /usr/include/signal.h:243:0, > from hipe/hipe_x86_signal.c:48: > /usr/include/bits/signal.h:129:0: note: this is the location of the > previous definition > #define _NSIG 65 > ^ > hipe/hipe_x86_signal.c:224:21: warning: no previous prototype for > '_sigaction' [-Wmissing-prototypes] > #define __SIGACTION _sigaction > ^ > hipe/hipe_x86_signal.c:266:5: note: in expansion of macro '__SIGACTION' > int __SIGACTION(int signum, const struct sigaction *act, struct sigaction > *olda > ^ > In file included from hipe/hipe_x86_signal.c:48:0: > hipe/hipe_x86_signal.c: In function 'hipe_signal_init': > hipe/hipe_x86_signal.c:233:15: error: '_NSIG' undeclared (first use in > this function) > #define _NSIG NSIG > ^ > hipe/hipe_x86_signal.c:341:21: note: in expansion of macro '_NSIG' > for (i = 1; i < _NSIG; ++i) { > ^ > hipe/hipe_x86_signal.c:233:15: note: each undeclared identifier is > reported only once for each function it appears in > #define _NSIG NSIG > ^ > hipe/hipe_x86_signal.c:341:21: note: in expansion of macro '_NSIG' > for (i = 1; i < _NSIG; ++i) { > ^ > x86_64-alpine-linux-musl/Makefile:956: recipe for target > 'obj/x86_64-alpine-linux-musl/opt/smp/hipe_x86_signal.o' failed > > This happened because you had m4 installed in your environment and I didn't. When m4 is found, hipe is enabled by default. If hipe is enabled, we need to apply an additional patch. I already have the patch working fine and will submit it among the other changes. My question is: should I add m4 to "makedepends" or should I assume it's already installed in your environment before you build the packages? > -nc > --001a114189b052db8d05210a0e4e Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

= 2015-09-30 9:40 GMT-03:00 Natanael Copa <ncopa@alpinelinux.org>= :
On Tue, 29 Sep 2015 00:51:43 = +0000
Marlus Saraiva <marlus.sarai= va@gmail.com> wrote:

> ---
>=C2=A0 .../0006-Do-not-install-erlang-sources.patch=C2=A0 =C2=A0 =C2=A0= =C2=A0| 531 +++++++++++++++------
>=C2=A0 main/erlang/APKBUILD=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2= =A0 26 +-
>=C2=A0 2 files changed, 382 insertions(+), 175 deletions(-)
>
> diff --git a/main/erlang/0006-Do-not-install-erlang-sources.patch b/ma= in/erlang/0006-Do-not-install-erlang-sources.patch
> index 8d14da5..9b7f421 100644
> --- a/main/erlang/0006-Do-not-install-erlang-sources.patch
> +++ b/main/erlang/0006-Do-not-install-erlang-sources.patch
> @@ -1,14 +1,5 @@
> -From: Hans Ulrich Niedermann <hun@n-dimensional.de>
> -Date: Mon, 21 Mar 2011 15:41:49 +0100
> -Subject: [PATCH] Do not install erlang sources
> -
> -Don't install *.erl, *.xrl, *.yrl, and *.asn1 files at all.
> -
> -Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
> -Signed-off-by: Hans Ulrich Niedermann <hun@n-dimensional.de>
> -

...

> +--- /dev/null
> ++++ otp_src_18.1-fixed/lib/ssh/src/Makefile.orig

I suppose adding Makefile.orig was not intentional?

=C2=A0
Sorry about that :)
=C2=A0=
I also get a build failure:
=C2=A0CC=C2=A0 =C2=A0 =C2=A0obj/x86_64-alpine-linux-musl/opt/smp/hipe_x86_s= ignal.o
hipe/hipe_x86_signal.c:233:0: warning: "_NSIG" redefined
=C2=A0#define _NSIG NSIG
=C2=A0^
In file included from /usr/include/signal.h:243:0,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0from hipe/hip= e_x86_signal.c:48:
/usr/include/bits/signal.h:129:0: note: this is the location of the previou= s definition
=C2=A0#define _NSIG 65
=C2=A0^
hipe/hipe_x86_signal.c:224:21: warning: no previous prototype for '_sig= action' [-Wmissing-prototypes]
=C2=A0#define __SIGACTION _sigaction
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0^
hipe/hipe_x86_signal.c:266:5: note: in expansion of macro '__SIGACTION&= #39;
=C2=A0int __SIGACTION(int signum, const struct sigaction *act, struct sigac= tion *olda
=C2=A0 =C2=A0 =C2=A0^
In file included from hipe/hipe_x86_signal.c:48:0:
hipe/hipe_x86_signal.c: In function 'hipe_signal_init':
hipe/hipe_x86_signal.c:233:15: error: '_NSIG' undeclared (first use= in this function)
=C2=A0#define _NSIG NSIG
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^
hipe/hipe_x86_signal.c:341:21: note: in expansion of macro '_NSIG'<= br> =C2=A0 =C2=A0 =C2=A0for (i =3D 1; i < _NSIG; ++i) {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0^
hipe/hipe_x86_signal.c:233:15: note: each undeclared identifier is reported= only once for each function it appears in
=C2=A0#define _NSIG NSIG
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^
hipe/hipe_x86_signal.c:341:21: note: in expansion of macro '_NSIG'<= br> =C2=A0 =C2=A0 =C2=A0for (i =3D 1; i < _NSIG; ++i) {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0^
x86_64-alpine-linux-musl/Makefile:956: recipe for target
'obj/x86_64-alpine-linux-musl/opt/smp/hipe_x86_signal.o' failed


This happened because you had m4 installed in your environ= ment and I didn't. When m4 is found, hipe is enabled by default. If hip= e is enabled, we need to apply an additional patch. I already have the patc= h working fine and will submit it among the other changes. My question is: = should I add m4 to "makedepends" or should I assume it's alre= ady installed in your environment before you build the packages?


-nc

--001a114189b052db8d05210a0e4e-- --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---