main/openrc: fix hostname init for btrfs subvolumes v1 PROPOSED

Stuart Cardall: 1
 main/openrc: fix hostname init for btrfs subvolumes

 1 files changed, 1 insertions(+), 5 deletions(-)

[alpine-aports] [PATCH] main/openrc: fix hostname init for btrfs subvolumes Export this patch

Busybox hostname doesn't seem to work on btrfs subvolumes (the hostname is set as "?")

This shell oneliner sets the hostname as the first non blank line in /etc/hostname.
If /etc/hostname is empty or does not exist the hostname is set to localhost.

Natanael Copa <ncopa@alpinelinux.org>

8 years ago

Does it set hostname if its nonempty?

Does it set hostname if its empty and filesystem is something else than
btrfs?

I wonder why this is specific for btrfs.

Next

---
 main/openrc/hostname.initd | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/main/openrc/hostname.initd b/main/openrc/hostname.initd
index fdc7f0b..49098f4 100644
--- a/main/openrc/hostname.initd
+++ b/main/openrc/hostname.initd
@@ -7,11 +7,7 @@ depend() {
 }
 
 start() {
-	if [ -f /etc/hostname ] ; then
-		opts="-F /etc/hostname"
-	else
-		opts="localhost"
-	fi
+	opts="$(grep -v '^$' /etc/hostname)" 2>/dev/null || opts="localhost"
 	ebegin "Setting hostname"
 	hostname $opts
 	eend $?

Natanael Copa <ncopa@alpinelinux.org>

8 years ago

Why not:

if [ -s /etc/hostname ]; then
    opts="-F /etc/hostname"
else
    opts="localhost"
fi

-nc


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---

-- 
2.6.3



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---