DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=subject:from:to:cc:in-reply-to:references:content-type:date
         :message-id:mime-version:x-mailer:content-transfer-encoding;
        b=hC7Yykzq8OMy7dEpwGRP+Yo2yfLdZqGv6SGlLpRtSEkT38tu5JAN4LB9Fq0RsBq1aR
         p9cy2ziSGtgF0SNDU6nD2gp30YL28VeZyGMUrZZvh0T7dWF254nYrDL6fl0CGw7n72zc
         AVLHNAGlFHldf168im1L+LAWVduerxgnqUTcM=
Subject: Re: [alpine-devel] new aport clamsmtp
From: Natanael Copa <natanael.copa@gmail.com>
To: Carlo Landmeter <clandmeter@gmail.com>
Cc: alpine <alpine-devel@lists.alpinelinux.org>
In-Reply-To: <20090203114416.2654C188BAC@smtp01.prioritytelecom.nl>
References: <20090203114416.2654C188BAC@smtp01.prioritytelecom.nl>
Content-Type: text/plain
Date: Tue, 03 Feb 2009 15:18:06 +0100
Message-Id: <1233670686.6926.77.camel@nc>
Precedence: list
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

On Tue, 2009-02-03 at 11:44 +0000, Carlo Landmeter wrote:
> From f1ce4e56e76edddbe583d01ad0289aba952f73ca Mon Sep 17 00:00:00 2001
> From: Carlo Landmeter <clandmeter@gmail.com>
> Date: Tue, 3 Feb 2009 11:42:48 +0000
> Subject: [PATCH] extra/clamstmp: new aport

maybe add pkg desc and url in the commit message for new aports in
future?

it is handy when looking at the commit logs

> ---
> diff --git a/extra/clamsmtp/clamsmtp.confd
> b/extra/clamsmtp/clamsmtp.confd
> new file mode 100644
> index 0000000..a2c9cf5
> --- /dev/null
> +++ b/extra/clamsmtp/clamsmtp.confd
> @@ -0,0 +1,5 @@
> +#
> +# Specify daemon $OPTS here.
> +#
> +
> +OPTS="-p /var/run/clamsmtpd.pid"

I dont think the pidfile shoudl be a configuration option since its set
hard in the init.d script...

> diff --git a/extra/clamsmtp/clamsmtp.initd
> b/extra/clamsmtp/clamsmtp.initd
> new file mode 100644
> index 0000000..4ccfe6c
> --- /dev/null
> +++ b/extra/clamsmtp/clamsmtp.initd
> @@ -0,0 +1,25 @@
> +#!/sbin/runscript
> +
> +# Sample init.d file for alpine linux.
> +
> +NAME=clamsmtpd
> +DAEMON=/usr/sbin/$NAME
> +
> +depend() {
> +       need net clamd
> +}
> +
> +start() {
> +       ebegin "Starting ${NAME}"
> +               start-stop-daemon --start --quiet \
> +                       --exec ${DAEMON} -- ${OPTS}

...so we should set the pidfile hard here too and not in the conf.d:

                   --exec ${DAEMON} -- ${OPTS} -p /var/run/$NAME.pid

> +       eend $?
> +}
> +
> +stop() {
> +       ebegin "Stopping ${NAME}"
> +               start-stop-daemon --stop --quiet \
> +                       --exec ${DAEMON} \
> +                       --pidfile /var/run/${NAME}.pid
> +       eend $?
> +}
> -- 
> 1.6.1


I committed it anyway.

Thanks!

-nc



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---