Date: Tue, 28 Dec 2010 15:42:23 +0100
From: Natanael Copa <ncopa@alpinelinux.org>
To: Jeff Bilyk <jbilyk@gmail.com>
Cc: alpine-devel@lists.alpinelinux.org
Subject: [alpine-devel] Re: [PATCH] alpine-conf: add script to add dl-3 internet repos from
 setup-alpine script
Message-ID: <20101228154223.5155c4ec@ncopa-desktop.nor.wtbts.net>
In-Reply-To: <AANLkTi=GiRU7vXE0u5wQchs4H6Xq1nJVR0S0oyXCFiXH@mail.gmail.com>
References: <1293137371-3175-1-git-send-email-jbilyk@gmail.com>
	<AANLkTi=GiRU7vXE0u5wQchs4H6Xq1nJVR0S0oyXCFiXH@mail.gmail.com>
Precedence: list
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 27 Dec 2010 18:10:52 -0500
Jeff Bilyk <jbilyk@gmail.com> wrote:

> Hey Natanael,
> 
> Thoughts on this patch?

sorry for beeing slow :-(

1. we should autodetect if its v2.2+ or edge. I don't think we need to
backport to pre v2.2. Also, we do not want modify this script everytiem
we make new release.

So what do you think about something like:

	release=$(cut -f1 /etc/alpine-release)
	case "$release" in
		*_git*) repo="edge";;
		[0-9]*.[0-9]*.[0-9]*)
			# release is in x.y.z format. lets cut the last
				digit
			repo=v${release%.[0-9]*};;
	esac
	
	if [ -z "$repo" ]; then
	  #prompt user
	fi

2. we should append the arch (right Timo?)

	case "$(uname -m)" in
		i[3-9]86) arch=x86;;
		x86_64) arch=x86_64;;
	esac


3. we should not have any hardcoded repo (dl-3.a.o) but we should fetch
a list of mirrors with wget and either present a choice for the users
or just pick one without any questions asked. I'd prefer the latter.

	mirror=$(wget -q -O - \
		http://www.alpinelinux.org/alpine/MIRRORS.txt \
		| head -n 1)

	url=$mirror/$repo/$arch
	...


That said, we gotta start from somewhere so I applied your patch.

Thanks for looking into this!

-nc


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---