Date: Sun, 9 Jan 2011 14:53:52 +0000
From: Natanael Copa <ncopa@alpinelinux.org>
To: Matt Smith <mcs@darkregion.net>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] [PATCH] main/php: improved APKBUILD, see changes
 [resent, updated]
Message-ID: <20110109145352.739b3b64@alpinelinux.org>
In-Reply-To: <1294428827-14536-1-git-send-email-mcs@darkregion.net>
References: <1294428827-14536-1-git-send-email-mcs@darkregion.net>
Precedence: list
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri,  7 Jan 2011 13:33:47 -0600
Matt Smith <mcs@darkregion.net> wrote:

> I based my updates off of Arch Linux's work for this package.

Thanks alot for working on this. I have felt i dont have capacity for
doing it myself so I am very happy that you do it and that you deliver
such high quality.

> Here's the changelog:
> - Each 'main subpackage' gets its own build dir, in order to eliminate
>   build-time complications.
> - Added php-cgi subpackage (in combination with the above change,
> fixes #505)

> - Added php-embed subpackage.

Is this needed? If not, can we add it when its needed or on request in
future?

> - Removed php-cli subpackage; it's now in the main 'php' package.

This means upgrades will break and that wiki docs needs updates.

Please try install alpine 2.1.4 in a virtual with php+lighttpd and have
a simple <?php phpinfo(); ?> script.

Then upgrade to edge and see what happens.

(you might need add some replaces="..." in there)

What do you think about keeping the php-cli package as separate
package, have the php as an empty meta package which has php-cgi as
depends (for not breaking upgraders), and have a php-common package
that holds the php.ini and shared files.

> - Added the configure options --with-readline and --enable-pcntl to
> the 'php' package (previously known as the php-cli package).

Is readline really needed? How often is php used from command line? You
dont need the readline support for running scripts.

I'm not saying I'm against readline, I'm  just thinking is it worth
the extra "bloat"?

> - Enabled the 'error_log' default option for php-fpm.conf
> - Enabled cgi.discard_path in php.ini, as --enable-discard-path was
> dropped from being a configure option.
> - Dropped --enable-force-cgi-redirect from configure options, as it
> was deprecated and enabled by default in php.ini.
> - Did away with $phpextensionsapache2 in the APKBUILD; seems it was
> there for a workaround.  Perhaps it was part of the #183 fix?
> (Apache still segfaults, with or without the $phpextensionsapache2
> workaround.)
> 
> For more info regarding PHP configure options:
> http://www.php.net/manual/en/configure.about.php
> 
> Also, can someone look over the updates I made to the #183 fix,
> regarding the above $phpextensionsapache2 workaround changes and the
> changes to where it says "# see #183" throughout the APKBUILD?  I
> want to make sure that I didn't break that fix.
> 
> Thanks,
> Matt
> 
> P.S.: I resent the patch to fix quoting the $srcdir variables and the
> like. e.g. From "$srcdir/$pkgname-$pkgver" to
> "$srcdir"/$pkgname-$pkgver ---
>  main/php/APKBUILD |  318
> +++++++++++++++++++++++++++++------------------------ 1 files
> changed, 172 insertions(+), 146 deletions(-)
> 

I still think we should fix it so we don't break things for people
upgrading. I applied it anyways since it is an improvment.

Thanks!

-nc


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---