Date: Thu, 17 Mar 2011 14:45:24 +0100
From: Natanael Copa <ncopa@alpinelinux.org>
To: Jeff Bilyk <jbilyk@gmail.com>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] [PATCH 1/2] testing/irrlicht: new aport
Message-ID: <20110317144524.6c80eb4c@ncopa-desktop.nor.wtbts.net>
In-Reply-To: <1300341666-9821-1-git-send-email-jbilyk@gmail.com>
References: <1300341666-9821-1-git-send-email-jbilyk@gmail.com>
Precedence: list
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 17 Mar 2011 06:01:05 +0000
Jeff Bilyk <jbilyk@gmail.com> wrote:

> ---
>  testing/irrlicht/APKBUILD |   73
> +++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 73
> insertions(+), 0 deletions(-) create mode 100644
> testing/irrlicht/APKBUILD
> 
> diff --git a/testing/irrlicht/APKBUILD b/testing/irrlicht/APKBUILD
> new file mode 100644
> index 0000000..8527cfe
> --- /dev/null
> +++ b/testing/irrlicht/APKBUILD
...
> +depends_dev="mesa-dev jpeg-dev bzip2"
> +makedepends="$depends_dev"


I might be wrong but it looked like you need zlib-dev and libpng-dev in
the makedepends as well.

> +
> +build() {
> +	cd "$_builddir"
> +	make sharedlib

I think it needs to be 'make sharedlib || return 1'. I noticed the
build fuilaed at some point (maybe parallell issue) but the package was
build anyways.

> +	make || return 1
> +

Thanks!
-nc


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---