Date: Mon, 2 May 2011 08:19:15 +0200
From: Natanael Copa <ncopa@alpinelinux.org>
To: Nathan Angelacos <nangel@alpinelinux.org>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] [PATCH] sems: create var/run/sems dir on install
Message-ID: <20110502081915.074b4bbe@ncopa-desktop.nor.wtbts.net>
In-Reply-To: <1304340206-3070-1-git-send-email-nangel@alpinelinux.org>
References: <1304340206-3070-1-git-send-email-nangel@alpinelinux.org>
Precedence: list
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon,  2 May 2011 12:43:26 +0000
Nathan Angelacos <nangel@alpinelinux.org> wrote:

> ---
>  testing/sems/APKBUILD |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/testing/sems/APKBUILD b/testing/sems/APKBUILD
> index 49a61ad..d9cb870 100644
> --- a/testing/sems/APKBUILD
> +++ b/testing/sems/APKBUILD
> @@ -76,6 +76,7 @@ package() {
>  	rm -f "$pkgdir"/etc/sems/etc/conf_auth.conf
>  
>  	install -o sems -g sems -d "$pkgdir"/var/spool/voicebox
> +	install -d -o sems  "$pkgdir"/var/run/sems
>  }
>  
>  _mv_sub() {

Is this really needed? I think we create the dir from init.d script in
case /var/run happens to be a tmpfs mount (yeah, we probably need a
major cleanup in lots of init.d scripts to get that actually working)

Secondly, always bump pkgrel when contents of package changes.
Otherwise it will not be rebuilt. And even if it would, people who has
it installed will not have it upgraded unless pkgver/pkgrel changes.

I applied it anyways and bumped pkgrel.

Thanks!

-nc


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---