Date: Thu, 14 Mar 2019 10:31:23 +0100
From: Natanael Copa <ncopa@alpinelinux.org>
To: Oliver Smith <ollieparanoid@bitmessage.ch>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] Extend APKBUILD format with a variable to check
 framework versions
Message-ID: <20190314103123.18921d4f@ncopa-desktop.copa.dup.pw>
In-Reply-To: <90ef5de9-9b84-7bec-dcce-4de4ef02a670@bitmessage.ch>
References: <c471c82c-f128-58ba-f903-1e25ad5c857d@bitmessage.ch>
	<20190109095332.410fd5f1@ncopa-desktop.copa.dup.pw>
	<f41c6ca2-3145-0eac-897d-ba284d1c992a@bitmessage.ch>
	<90ef5de9-9b84-7bec-dcce-4de4ef02a670@bitmessage.ch>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Wed, 13 Mar 2019 08:47:00 +0000
Oliver Smith <ollieparanoid@bitmessage.ch> wrote:

> Hello again,

Hi!

Thank you for working on this.
=20
> here is the script. I placed it in its own git repository, to add tests
> and a CI config in the same place, without cluttering Alpine's existing
> repositories. The script itself is less than 100 lines (with comments)
> and should basically work everywhere out of the box without installing
> anything.
>=20
> https://github.com/ollieparanoid/aports-relgroup-check/blob/master/relgro=
up-check.sh
>=20
> See the "tests" dir of the same repository for example output.
>=20
> My idea is, that this gets forked and maintained over at Alpine's github
> organization. Then aports.git (and postmarketOS' pmaports.git, and
> Ad=E9lie's repo) can download and run the script in their CI code.
>=20
> What do you think folks?



I looked at the script and tested it a bit. A few general comments:

- Would be nice to be able to specify APORTS dir as an arg, and if its
  omitted  (and $APORTS is empty) then use current dir.

- I like that you use `find` to find the APKBUILDs

- I think we may need parse/execute the entire APKBUILD to get the
  relgroup, so that things like relgroup=3Dqt${pkgver%%.*} works.

- the script is a bit slow. Probably because there are forks for each
  APKBUILD.

Sounds like a good idea to keep it in the alpinelinux' org. I don't
know if we want keep it on git.alpinelinux.org? What does infra team
think?

-nc


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---