DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=qpf1qN1tZ4hEVREIC9w+eo31uqlQ30bZUQ4/typSfBHV1rwihfddN2v6ydcbii0mcV
         gWv16/wEnwW395c93cKzyfOfspvhKgbIiURj8Txaq6ewyfl2ctzPO7lOnGCvKi+mRIWu
         UD8nzTsxqZIOdU/ijBxcFRkWqCdDWiS54CVYc=
Precedence: list
MIME-Version: 1.0
In-Reply-To: <076ca6456d9b67f0938f5f1fbd8b3720@ytre.org>
References: <076ca6456d9b67f0938f5f1fbd8b3720@ytre.org>
Date: Mon, 28 Feb 2011 12:10:34 -0500
Message-ID: <AANLkTin=fZwzna9s-Ddhu3UQYqAHucXtCyboDTiQ5FVD@mail.gmail.com>
Subject: Re: [alpine-devel] comments on setup-apkrepos
From: Jeff Bilyk <jbilyk@gmail.com>
To: Natanael Copa <ncopa@alpinelinux.org>
Cc: alpine-devel@lists.alpinelinux.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Mon, Feb 28, 2011 at 10:21 AM, Natanael Copa <ncopa@alpinelinux.org> wro=
te:
> Hi,
>
> Nice work that has been done on setup-apkrepos!
>
> I have a few minor comments.
>
> 1) Try avoid =3D=3D operator.
> Its bash specific, and even if it is implemented in busybox ash, its no
> guarantee it will in future.
>
> replace:
>
> =A0if [ $var =3D=3D "something" ]; then
>
> with:
>
> =A0if [ "$var" =3D "something" ]; then
>
> For the specific case in setup-apkrepos, I think that case ... in would b=
e
> better:
>
> case "$setup_method" in
> =A0random)
> =A0 =A0get_random_method;;
> =A0fastest)
> =A0 =A0get_fastest_mirror;;
> =A0mirror_list)
> =A0 =A0prompt_mirror_list;;
> =A0custom_mirror)
> =A0 =A0prompt_clear_repositories;;
> esac
>
>
> 2) I dont like the 2 y/n questions at setup-alpine end.
> Setup internet apk repositories? [y/N]?
> Change timezone (default is UTC)? [y/N]?
>
> I think we don't need those questions. Better would be
>
> How would you like to set up the apk repostories?
> 1) Automatically...
> ...
> 5) do not setup apk repositories at all.
> Please select how to setup APK repositories [5]:
>
>
> Then we have 1 less question to ask user.
>
> Same goes for timezone.
>
> If you are ok with it I'll change the above.
I'm fine with those changes, change away :).
>
> I will have a look at the setup-disk script and then make an alpine-conf =
2.6
> release with the new stuff.
>
> Thanks!
>
>
> ---
> Unsubscribe: =A0alpine-devel+unsubscribe@lists.alpinelinux.org
> Help: =A0 =A0 =A0 =A0 alpine-devel+help@lists.alpinelinux.org
> ---
>
>

--=20
Jeff


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---