~alpine/aports

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
2 2

[alpine-aports] [PATCH] main/geany: fix vte emulation

Details
Message ID
<1421924516-14944-1-git-send-email-amatcoder@gmail.com>
Sender timestamp
1421924516
DKIM signature
missing
Download raw message
Patch: +2 -2
Replace only the first 'xterm' because the other is the terminal
emulation to use and it must be 'xterm'.
---
 main/geany/APKBUILD | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/main/geany/APKBUILD b/main/geany/APKBUILD
index 12597d0..eceec52 100644
--- a/main/geany/APKBUILD
+++ b/main/geany/APKBUILD
@@ -1,7 +1,7 @@
# Maintainer: Natanael Copa <ncopa@alpinelinux.org>
pkgname=geany
pkgver=1.24.1
pkgrel=0
pkgrel=1
pkgdesc="A fast and lightweight IDE"
url="http://www.geany.org"
arch="all"
@@ -47,7 +47,7 @@ prepare() {
                esac
        done
	# set default terminal to Terminal
	sed -e 's/xterm/Terminal/g' \
	sed -e '1,/xterm/s/xterm/Terminal/' \
		-i src/keyfile.c
}

-- 
2.2.2



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---
Natanael Copa <ncopa@alpinelinux.org>
Details
Message ID
<20150125122740.0d2a3843@ncopa-laptop>
In-Reply-To
<1421924516-14944-1-git-send-email-amatcoder@gmail.com> (view parent)
Sender timestamp
1422185260
DKIM signature
missing
Download raw message
On Thu, 22 Jan 2015 11:01:56 +0000
AmatCoder <amatcoder@gmail.com> wrote:

> Replace only the first 'xterm' because the other is the terminal
> emulation to use and it must be 'xterm'.
> ---
>  main/geany/APKBUILD | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/main/geany/APKBUILD b/main/geany/APKBUILD
> index 12597d0..eceec52 100644
> --- a/main/geany/APKBUILD
> +++ b/main/geany/APKBUILD
> @@ -1,7 +1,7 @@
>  # Maintainer: Natanael Copa <ncopa@alpinelinux.org>
>  pkgname=geany
>  pkgver=1.24.1
> -pkgrel=0
> +pkgrel=1
>  pkgdesc="A fast and lightweight IDE"
>  url="http://www.geany.org"
>  arch="all"
> @@ -47,7 +47,7 @@ prepare() {
>                  esac
>          done
>  	# set default terminal to Terminal
> -	sed -e 's/xterm/Terminal/g' \
> +	sed -e '1,/xterm/s/xterm/Terminal/' \
>  		-i src/keyfile.c
>  }
>  

I wonder if it would be better to implement it as a patch instead of
sed. If they for some reason would insert 'xterm' in a comment or
whatever it will break things again.

-nc


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---
Details
Message ID
<CAHLLVvF9QsCeWMPn2uTT92MnLDPWo=bJOsrcoV4hkWiKyj_cBQ@mail.gmail.com>
In-Reply-To
<20150125122740.0d2a3843@ncopa-laptop> (view parent)
Sender timestamp
1422199004
DKIM signature
missing
Download raw message
2015-01-25 11:27 GMT+00:00 Natanael Copa <ncopa@alpinelinux.org>:

>
> I wonder if it would be better to implement it as a patch instead of
> sed. If they for some reason would insert 'xterm' in a comment or
> whatever it will break things again.
>
> -nc
>

Yes, it would be better. I will do it tomorrow.
Reply to thread Export thread (mbox)