~alpine/aports

1

[alpine-aports] [PATCH] main/busybox: prevent abuild from complaining about /tmp during build

Details
Message ID
<1438031410-1345-1-git-send-email-soeren+git@soeren-tempel.net>
Sender timestamp
1438031410
DKIM signature
missing
Download raw message
Patch: +4 -2
---
 main/busybox/APKBUILD | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/main/busybox/APKBUILD b/main/busybox/APKBUILD
index a950f84..0d0ebb7 100644
--- a/main/busybox/APKBUILD
+++ b/main/busybox/APKBUILD
@@ -82,7 +82,6 @@ build() {
	make -C "$_sdir" O="$PWD" silentoldconfig || return 1
	make || return 1
	mv busybox busybox.static

}

package() {
@@ -95,7 +94,7 @@ package() {
	# we need /bin/sh to be able to execute post-install
	ln -s /bin/busybox "$pkgdir"/bin/sh

	#ifupdown needs those dirs to be present
	# ifupdown needs those dirs to be present
	mkdir -p \
		"$pkgdir"/etc/network/if-down.d \
		"$pkgdir"/etc/network/if-post-down.d \
@@ -104,6 +103,9 @@ package() {
		"$pkgdir"/etc/network/if-pre-up.d \
		"$pkgdir"/etc/network/if-up.d \
		|| return 1

	# prevent abuild from complaining about /tmp
	rm -rf "$pkgdir/tmp"
}

static() {
-- 
2.4.6



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---
Natanael Copa <ncopa@alpinelinux.org>
Details
Message ID
<20150728103354.519687c1@ncopa-desktop.alpinelinux.org>
In-Reply-To
<1438031410-1345-1-git-send-email-soeren+git@soeren-tempel.net> (view parent)
Sender timestamp
1438072434
DKIM signature
missing
Download raw message
On Mon, 27 Jul 2015 23:10:10 +0200
Sören Tempel <soeren+git@soeren-tempel.net> wrote:

> ---
>  main/busybox/APKBUILD | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/main/busybox/APKBUILD b/main/busybox/APKBUILD
> index a950f84..0d0ebb7 100644
> --- a/main/busybox/APKBUILD
> +++ b/main/busybox/APKBUILD
> @@ -82,7 +82,6 @@ build() {
>  	make -C "$_sdir" O="$PWD" silentoldconfig || return 1
>  	make || return 1
>  	mv busybox busybox.static
> -
>  }
>  
>  package() {
> @@ -95,7 +94,7 @@ package() {
>  	# we need /bin/sh to be able to execute post-install
>  	ln -s /bin/busybox "$pkgdir"/bin/sh
>  
> -	#ifupdown needs those dirs to be present
> +	# ifupdown needs those dirs to be present
>  	mkdir -p \
>  		"$pkgdir"/etc/network/if-down.d \
>  		"$pkgdir"/etc/network/if-post-down.d \
> @@ -104,6 +103,9 @@ package() {
>  		"$pkgdir"/etc/network/if-pre-up.d \
>  		"$pkgdir"/etc/network/if-up.d \
>  		|| return 1
> +
> +	# prevent abuild from complaining about /tmp
> +	rm -rf "$pkgdir/tmp"

NACK.

If we want remove it, then better not create it (the package function
does mkdir).

But I think we created it for a reason in the first place. git blame
gave me commit 8b60075.
http://git.alpinelinux.org/cgit/aports/commit/?id=8b60075

Which explains that we need /tmp early for install script when
bootstrapping a new root with apkovl.

-nc


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---
Reply to thread Export thread (mbox)