On Thu, Sep 10, 2015 at 05:02:42PM +0200, Sören Tempel wrote:
> -makedepends="dbus-dev"> +depends_dev="dbus-dev"> +makedepends="$makedepends"
I had been under the impression that depends_dev was for packages that
should be dependencies of the -dev suppackage.
Thanks,
Isaac
---
Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org
Help: alpine-aports+help@lists.alpinelinux.org
---
[alpine-aports] [PATCH 2/2] main/dhcpcd-dbus: use depends_dev
On Sep 10, 2015 19:59, "Isaac Dunham" <ibid.ag@gmail.com> wrote:
>> On Thu, Sep 10, 2015 at 05:02:42PM +0200, Sören Tempel wrote:> > -makedepends="dbus-dev"> > +depends_dev="dbus-dev"> > +makedepends="$makedepends">> I had been under the impression that depends_dev was for packages that> should be dependencies of the -dev suppackage.>
You are correct. Since there is no -dev package this does not make sense.
In addition there is a typo in the patch which should make the package
unbuildable.
Eivind
Re: [alpine-aports] [PATCH 2/2] main/dhcpcd-dbus: use depends_dev
On Thu, 10 Sep 2015 17:02:42 +0200
Sören Tempel <soeren+git@soeren-tempel.net> wrote:
> ---> main/dhcpcd-dbus/APKBUILD | 7 ++++---> 1 file changed, 4 insertions(+), 3 deletions(-)> > diff --git a/main/dhcpcd-dbus/APKBUILD b/main/dhcpcd-dbus/APKBUILD> index da90f90..5e235f3 100644> --- a/main/dhcpcd-dbus/APKBUILD> +++ b/main/dhcpcd-dbus/APKBUILD> @@ -7,7 +7,8 @@ url="http://roy.marples.name/projects/dhcpcd-dbus"> arch="all"> license="BSD"> depends=""> -makedepends="dbus-dev"> +depends_dev="dbus-dev"> +makedepends="$makedepends"
NACK.
as Dunham and Uggedal explained, the depends_dev will only set the
dependency for -dev subpackage. It makes no sense to use depends_dev if
there are no -dev subpackage.
-nc
---
Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org
Help: alpine-aports+help@lists.alpinelinux.org
---