~alpine/aports

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
2

[alpine-aports] [PATCH] main/dovecot: a change after the previous patch, added basedir creation in init-script

Valery Kartel <valery.kartel@gmail.com>
Details
Message ID
<1449662731-27066-1-git-send-email-valery.kartel@gmail.com>
Sender timestamp
1449662731
DKIM signature
missing
Download raw message
8 years ago
Patch: +1 -0 
---
 main/dovecot/dovecot.initd | 1 +
 1 file changed, 1 insertion(+)

diff --git a/main/dovecot/dovecot.initd b/main/dovecot/dovecot.initd
index 6cc9cb0..d74e71e 100644
--- a/main/dovecot/dovecot.initd
+++ b/main/dovecot/dovecot.initd
@@ -31,6 +31,7 @@ checkconfig() {
	fi
	DOVECOT_BASEDIR=${DOVECOT_BASEDIR:-/run/dovecot}
	DOVECOT_PIDFILE=${DOVECOT_BASEDIR}/master.pid
	checkpath --directory --owner dovecot:dovecot --mode 0750 ${DOVECOT_BASEDIR}
}

start() {
-- 
2.6.3



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---
Natanael Copa <ncopa@alpinelinux.org>
Details
Message ID
<20151209151438.155ca114@ncopa-desktop.alpinelinux.org>
In-Reply-To
<1449662731-27066-1-git-send-email-valery.kartel@gmail.com> (view parent)
Sender timestamp
1449670478
DKIM signature
missing
Download raw message
8 years ago 
On Wed,  9 Dec 2015 14:05:31 +0200
Valery Kartel <valery.kartel@gmail.com> wrote:

> ---
>  main/dovecot/dovecot.initd | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/main/dovecot/dovecot.initd b/main/dovecot/dovecot.initd
> index 6cc9cb0..d74e71e 100644
> --- a/main/dovecot/dovecot.initd
> +++ b/main/dovecot/dovecot.initd
> @@ -31,6 +31,7 @@ checkconfig() {
>  	fi
>  	DOVECOT_BASEDIR=${DOVECOT_BASEDIR:-/run/dovecot}
>  	DOVECOT_PIDFILE=${DOVECOT_BASEDIR}/master.pid
> +	checkpath --directory --owner dovecot:dovecot --mode 0750 ${DOVECOT_BASEDIR}
>  }
>  
>  start() {

are you sure that --mode 0750 is correct? I get this when I start dovecot:

 * Starting dovecot ...
Warning: Fixing permissions of /run/dovecot to be world-readable          [ ok ]

-nc


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---
Natanael Copa <ncopa@alpinelinux.org>
Details
Message ID
<20151209152148.6e7bde53@ncopa-desktop.alpinelinux.org>
In-Reply-To
<20151209151438.155ca114@ncopa-desktop.alpinelinux.org> (view parent)
Sender timestamp
1449670908
DKIM signature
missing
Download raw message
8 years ago 
On Wed, 9 Dec 2015 15:14:38 +0100
Natanael Copa <ncopa@alpinelinux.org> wrote:

> On Wed,  9 Dec 2015 14:05:31 +0200
> Valery Kartel <valery.kartel@gmail.com> wrote:
> 
> > ---
> >  main/dovecot/dovecot.initd | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/main/dovecot/dovecot.initd b/main/dovecot/dovecot.initd
> > index 6cc9cb0..d74e71e 100644
> > --- a/main/dovecot/dovecot.initd
> > +++ b/main/dovecot/dovecot.initd
> > @@ -31,6 +31,7 @@ checkconfig() {
> >  	fi
> >  	DOVECOT_BASEDIR=${DOVECOT_BASEDIR:-/run/dovecot}
> >  	DOVECOT_PIDFILE=${DOVECOT_BASEDIR}/master.pid
> > +	checkpath --directory --owner dovecot:dovecot --mode 0750 ${DOVECOT_BASEDIR}
> >  }
> >  
> >  start() {  
> 
> are you sure that --mode 0750 is correct? I get this when I start dovecot:
> 
>  * Starting dovecot ...
> Warning: Fixing permissions of /run/dovecot to be world-readable          [ ok ]

I changed it to '--mode 755', merged it with your previous patch,
rebased it against my dovecot update, fixed the checksums and pushed.

Thanks!

-nc


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---
Reply to thread Export thread (mbox)