~alpine/aports

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
4 2

[alpine-aports] [PATCH] main/libspf2: 'spfquery' binary moved to -query subpackage, other binary examples are removed

Details
Message ID
<1450097413-13305-1-git-send-email-valery.kartel@gmail.com>
Sender timestamp
1450097413
DKIM signature
missing
Download raw message
Patch: +11 -2
---
 main/libspf2/APKBUILD | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/main/libspf2/APKBUILD b/main/libspf2/APKBUILD
index 5484e46..103400e 100644
--- a/main/libspf2/APKBUILD
+++ b/main/libspf2/APKBUILD
@@ -1,12 +1,13 @@
# Contributor: Valery Kartel <valery.kartel@gmail.com>
# Maintainer: Natanael Copa <ncopa@alpinelinux.org>
pkgname=libspf2
pkgver=1.2.10
pkgrel=1
pkgrel=2
pkgdesc="Sender Policy Framework library, a part of the SPF/SRS protocol pair."
url="http://www.libspf2.org"
arch="all"
license="LGPL2.1 BSD-2"
subpackages="$pkgname-dev"
subpackages="$pkgname-dev $pkgname-query"
makedepends="autoconf automake libtool"
depends=
source="http://www.libspf2.org/spf/libspf2-$pkgver.tar.gz
@@ -44,6 +45,14 @@ package() {
	cd "$_builddir"
	make DESTDIR="$pkgdir" install || return 1
}

query() {
	pkgdesc="SPF command-line utility"
	mkdir -p "$subpkgdir"/usr/bin
	mv "$pkgdir"/usr/bin/spfquery "$subpkgdir"/usr/bin/
	rm -fr "$pkgdir"/usr/bin
}

md5sums="7bb9937d0705649eaa8646de66dc3562  libspf2-1.2.10.tar.gz
24b77cb74901d56de89b24ef10b46b85  0001-provide-dn_skipname.patch
6dd2d5f33c5f1a5b7c14eec4c71767cd  libspf2-libreplace-fix.patch
-- 
2.6.3



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---

Re: [alpine-aports] main/libspf2: 'spfquery' binary moved to -query subpackage, other binary examples are removed

Timo Teras <timo.teras@iki.fi>
Details
Message ID
<20160119141101.5af72257@vostro>
In-Reply-To
<1450097413-13305-1-git-send-email-valery.kartel@gmail.com> (view parent)
Sender timestamp
1453205461
DKIM signature
missing
Download raw message
On Mon, 14 Dec 2015 14:50:13 +0200
Valery Kartel <valery.kartel@gmail.com> wrote:

> ---
>  main/libspf2/APKBUILD | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/main/libspf2/APKBUILD b/main/libspf2/APKBUILD
> index 5484e46..103400e 100644
> --- a/main/libspf2/APKBUILD
> +++ b/main/libspf2/APKBUILD
> @@ -1,12 +1,13 @@
> +# Contributor: Valery Kartel <valery.kartel@gmail.com>
>  # Maintainer: Natanael Copa <ncopa@alpinelinux.org>
>  pkgname=libspf2
>  pkgver=1.2.10
> -pkgrel=1
> +pkgrel=2
>  pkgdesc="Sender Policy Framework library, a part of the SPF/SRS
> protocol pair." url="http://www.libspf2.org"
>  arch="all"
>  license="LGPL2.1 BSD-2"
> -subpackages="$pkgname-dev"
> +subpackages="$pkgname-dev $pkgname-query"
>  makedepends="autoconf automake libtool"
>  depends=
>  source="http://www.libspf2.org/spf/libspf2-$pkgver.tar.gz
> @@ -44,6 +45,14 @@ package() {
>  	cd "$_builddir"
>  	make DESTDIR="$pkgdir" install || return 1
>  }
> +
> +query() {
> +	pkgdesc="SPF command-line utility"
> +	mkdir -p "$subpkgdir"/usr/bin
> +	mv "$pkgdir"/usr/bin/spfquery "$subpkgdir"/usr/bin/
> +	rm -fr "$pkgdir"/usr/bin

How about spfd? I think that should be kept in the base pkg. The others
can go. Perhaps also use --disable-static to configure to prevent the
static binary building?

Otherwise it looks ok. Care to resend with the above changes?

Thanks,
Timo

> +}
> +
>  md5sums="7bb9937d0705649eaa8646de66dc3562  libspf2-1.2.10.tar.gz
>  24b77cb74901d56de89b24ef10b46b85  0001-provide-dn_skipname.patch
>  6dd2d5f33c5f1a5b7c14eec4c71767cd  libspf2-libreplace-fix.patch



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---

Re: [alpine-aports] main/libspf2: 'spfquery' binary moved to -query subpackage, other binary examples are removed

Details
Message ID
<CAKTwcDOfY-3jHvL25M42QNeN_eU=fktfwMiK7DJ5259Gsj7M8A@mail.gmail.com>
In-Reply-To
<20160119141101.5af72257@vostro> (view parent)
Sender timestamp
1453245911
DKIM signature
missing
Download raw message
spfd is an ancient interface to libspf2. All spf-related things use it's
api, not a daemon. About static, don't know why I stay it there. Maybe for
-dev... don't know in any way. I resend it with static disabled and move
spfd to separate subpackage.
19 січ. 2016 14:11 "Timo Teras" <timo.teras@iki.fi> пише:

> On Mon, 14 Dec 2015 14:50:13 +0200
> Valery Kartel <valery.kartel@gmail.com> wrote:
>
> > ---
> >  main/libspf2/APKBUILD | 13 +++++++++++--
> >  1 file changed, 11 insertions(+), 2 deletions(-)
> >
> > diff --git a/main/libspf2/APKBUILD b/main/libspf2/APKBUILD
> > index 5484e46..103400e 100644
> > --- a/main/libspf2/APKBUILD
> > +++ b/main/libspf2/APKBUILD
> > @@ -1,12 +1,13 @@
> > +# Contributor: Valery Kartel <valery.kartel@gmail.com>
> >  # Maintainer: Natanael Copa <ncopa@alpinelinux.org>
> >  pkgname=libspf2
> >  pkgver=1.2.10
> > -pkgrel=1
> > +pkgrel=2
> >  pkgdesc="Sender Policy Framework library, a part of the SPF/SRS
> > protocol pair." url="http://www.libspf2.org"
> >  arch="all"
> >  license="LGPL2.1 BSD-2"
> > -subpackages="$pkgname-dev"
> > +subpackages="$pkgname-dev $pkgname-query"
> >  makedepends="autoconf automake libtool"
> >  depends=
> >  source="http://www.libspf2.org/spf/libspf2-$pkgver.tar.gz
> > @@ -44,6 +45,14 @@ package() {
> >       cd "$_builddir"
> >       make DESTDIR="$pkgdir" install || return 1
> >  }
> > +
> > +query() {
> > +     pkgdesc="SPF command-line utility"
> > +     mkdir -p "$subpkgdir"/usr/bin
> > +     mv "$pkgdir"/usr/bin/spfquery "$subpkgdir"/usr/bin/
> > +     rm -fr "$pkgdir"/usr/bin
>
> How about spfd? I think that should be kept in the base pkg. The others
> can go. Perhaps also use --disable-static to configure to prevent the
> static binary building?
>
> Otherwise it looks ok. Care to resend with the above changes?
>
> Thanks,
> Timo
>
> > +}
> > +
> >  md5sums="7bb9937d0705649eaa8646de66dc3562  libspf2-1.2.10.tar.gz
> >  24b77cb74901d56de89b24ef10b46b85  0001-provide-dn_skipname.patch
> >  6dd2d5f33c5f1a5b7c14eec4c71767cd  libspf2-libreplace-fix.patch
>
>

Re: [alpine-aports] main/libspf2: 'spfquery' binary moved to -query subpackage, other binary examples are removed

Details
Message ID
<CAKTwcDPc59zOdNkyippHfrVtitNDZzqBBj3G_VGOS5BvYY3-oQ@mail.gmail.com>
In-Reply-To
<20160119141101.5af72257@vostro> (view parent)
Sender timestamp
1453288530
DKIM signature
missing
Download raw message
It does not compile with --disable-static, because *_static binaties are
compiled automatically. So we just delete /usr/bin folder after moving
spfquery to subpackage.

And about spfd: it's an example code, A brief description from spfd.c:
* This program is really a badly smashed together copy of spfquery.c and
 * the public domain "helloserver" example daemon.
 *
 * Implements a skeleton of a single process iterative server
 * daemon.

Patch remained unchanged, so you can take it as is.

2016-01-19 14:11 GMT+02:00 Timo Teras <timo.teras@iki.fi>:

> On Mon, 14 Dec 2015 14:50:13 +0200
> Valery Kartel <valery.kartel@gmail.com> wrote:
>
> > ---
> >  main/libspf2/APKBUILD | 13 +++++++++++--
> >  1 file changed, 11 insertions(+), 2 deletions(-)
> >
> > diff --git a/main/libspf2/APKBUILD b/main/libspf2/APKBUILD
> > index 5484e46..103400e 100644
> > --- a/main/libspf2/APKBUILD
> > +++ b/main/libspf2/APKBUILD
> > @@ -1,12 +1,13 @@
> > +# Contributor: Valery Kartel <valery.kartel@gmail.com>
> >  # Maintainer: Natanael Copa <ncopa@alpinelinux.org>
> >  pkgname=libspf2
> >  pkgver=1.2.10
> > -pkgrel=1
> > +pkgrel=2
> >  pkgdesc="Sender Policy Framework library, a part of the SPF/SRS
> > protocol pair." url="http://www.libspf2.org"
> >  arch="all"
> >  license="LGPL2.1 BSD-2"
> > -subpackages="$pkgname-dev"
> > +subpackages="$pkgname-dev $pkgname-query"
> >  makedepends="autoconf automake libtool"
> >  depends=
> >  source="http://www.libspf2.org/spf/libspf2-$pkgver.tar.gz
> > @@ -44,6 +45,14 @@ package() {
> >       cd "$_builddir"
> >       make DESTDIR="$pkgdir" install || return 1
> >  }
> > +
> > +query() {
> > +     pkgdesc="SPF command-line utility"
> > +     mkdir -p "$subpkgdir"/usr/bin
> > +     mv "$pkgdir"/usr/bin/spfquery "$subpkgdir"/usr/bin/
> > +     rm -fr "$pkgdir"/usr/bin
>
> How about spfd? I think that should be kept in the base pkg. The others
> can go. Perhaps also use --disable-static to configure to prevent the
> static binary building?
>
> Otherwise it looks ok. Care to resend with the above changes?
>
> Thanks,
> Timo
>
> > +}
> > +
> >  md5sums="7bb9937d0705649eaa8646de66dc3562  libspf2-1.2.10.tar.gz
> >  24b77cb74901d56de89b24ef10b46b85  0001-provide-dn_skipname.patch
> >  6dd2d5f33c5f1a5b7c14eec4c71767cd  libspf2-libreplace-fix.patch
>
>

Re: [alpine-aports] main/libspf2: 'spfquery' binary moved to -query subpackage, other binary examples are removed

Timo Teras <timo.teras@iki.fi>
Details
Message ID
<20160121102941.32172cb6@vostro>
In-Reply-To
<CAKTwcDPc59zOdNkyippHfrVtitNDZzqBBj3G_VGOS5BvYY3-oQ@mail.gmail.com> (view parent)
Sender timestamp
1453364981
DKIM signature
missing
Download raw message
On Wed, 20 Jan 2016 13:15:30 +0200
Valery Kartel <valery.kartel@gmail.com> wrote:

> It does not compile with --disable-static, because *_static binaties
> are compiled automatically. So we just delete /usr/bin folder after
> moving spfquery to subpackage.

Ok.

> And about spfd: it's an example code, A brief description from spfd.c:
> * This program is really a badly smashed together copy of spfquery.c
> and
>  * the public domain "helloserver" example daemon.
>  *
>  * Implements a skeleton of a single process iterative server
>  * daemon.
> 
> Patch remained unchanged, so you can take it as is.

But I want to keep spfd. It's standard interface. There's several
implementations but the "badly smashed together copy" outperforms the
perl and python alternatives.

Perhaps make it -tools subpackage and put both spfd and spfdquery into
it?

If there's name conflict, you can rename it to spfd.libspf2 or similar.

Thanks,
Timo


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---
Reply to thread Export thread (mbox)