On Wed, Feb 24, 2016 at 07:38:26AM +0000, Hervé Rousseau wrote:
> (with correct commit msg/subject it's always better)> > APKBUILD specifies --with-xmlrpc-c but support isn't enabled because libxm2-dev is missing.> ./configure returns this:> checking for XMLRPC-C... /usr/bin/xmlrpc-c-config: line 66: xml2-config: not found> /usr/bin/xmlrpc-c-config: line 66: xml2-config: not found
I see two issues with this patch:
- you need to bump pkgrel to trigger a rebuild
- that error means that the xmlrpc-c-config script is missing a dependency
that it should have.
In other words, xmlrpc-c-dev ideally should depend on libxml2-dev, because
it's not possible to use it without libxml2-dev.
Of course, if you fix that, you'd still need to bump rtorrent to pick up
the fix (and possibly more packages).
HTH,
Isaac Dunham
> ---> main/rtorrent/APKBUILD | 2 +-> 1 file changed, 1 insertion(+), 1 deletion(-)> > diff --git a/main/rtorrent/APKBUILD b/main/rtorrent/APKBUILD> index 2ef3c4b..49a9462 100644> --- a/main/rtorrent/APKBUILD> +++ b/main/rtorrent/APKBUILD> @@ -8,7 +8,7 @@ pkgdesc="Ncurses BitTorrent client based on libTorrent"> url="http://rakshasa.github.io/rtorrent/"> license="GPL"> arch="all"> -makedepends="libsigc++-dev libtorrent-dev curl-dev xmlrpc-c-dev ncurses-dev"> +makedepends="libsigc++-dev libtorrent-dev libxml2-dev curl-dev xmlrpc-c-dev ncurses-dev"> subpackages="$pkgname-doc"> source="http://rtorrent.net/downloads/${pkgname}-${pkgver}.tar.gz"> > -- > 2.6.4> > > > ---> Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org> Help: alpine-aports+help@lists.alpinelinux.org> --->
---
Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org
Help: alpine-aports+help@lists.alpinelinux.org
---
On Wed, 24 Feb 2016 18:49:36 -0800
Isaac Dunham <ibid.ag@gmail.com> wrote:
> On Wed, Feb 24, 2016 at 07:38:26AM +0000, Hervé Rousseau wrote:> > (with correct commit msg/subject it's always better)> > > > APKBUILD specifies --with-xmlrpc-c but support isn't enabled because libxm2-dev is missing.> > ./configure returns this:> > checking for XMLRPC-C... /usr/bin/xmlrpc-c-config: line 66: xml2-config: not found> > /usr/bin/xmlrpc-c-config: line 66: xml2-config: not found > > I see two issues with this patch:> - you need to bump pkgrel to trigger a rebuild> > - that error means that the xmlrpc-c-config script is missing a dependency> that it should have.> > In other words, xmlrpc-c-dev ideally should depend on libxml2-dev, because> it's not possible to use it without libxml2-dev.> > Of course, if you fix that, you'd still need to bump rtorrent to pick up> the fix (and possibly more packages).
I agree with Dunham on all those.
I'd also like commit message reformatted (wrap words at 72 chars,
remove text that is not intended for the git history)
Thanks!
-nc
---
Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org
Help: alpine-aports+help@lists.alpinelinux.org
---
[alpine-aports] [PATCH v2 1/2] main/xmlrpc-c: add depends_dev on libxml2-dev