On 28.02.16, Trevor R.H. Clarke wrote:
> +depends_py="gdal python"
I have never heard of this variable. I don't think that abuild actually
uses this for anything…
On 28.02.16, Trevor R.H. Clarke wrote:
> +prepare() {> + local i> + cd "$_builddir"> + for i in $source; do> + case $i in> + *.patch) msg $i; patch -p1 -i "$srcdir"/$i || return 1;;> + esac> + done> +}
As of abuild 2.26.0 this is the default prepare function you no longer
need to supply it explicitly.
On 28.02.16, Trevor R.H. Clarke wrote:
> +build() {> + cd "$_builddir"> + ./configure --prefix=/usr> + make -j8 || return 1> +}
You don't want to explicitly pass -j8 to make here. Usually the amount
of makejobs to use is set using the MAKEFLAGS environment variable in
abuild.conf. Generally speaking -j is only set explicitly when the
package doesn't support parallel builds.
On 28.02.16, Trevor R.H. Clarke wrote:
> +py() {> + pkgdesc="$pkgname python bindings" > + mkdir -p "$subpkgdir"/usr/lib> + mkdir -p "$subpkgdir"/usr/bin> + cd "$_builddir"/swig/python> + python setup.py build || return 1> + python setup.py install --prefix=/usr --root="$subpkgdir"> + chmod a+x scripts/*> + cp scripts/* $subpkgdir/usr/bin/> +}
This doesn't seem to be indented correctly and also contains
whitespaces. Please indent everything with tabs and remove the
whitespaces. Also it would probably be easier to install the scripts
using install(1) and pass -m755 but that's just a minor thing.
On 28.02.16, Trevor R.H. Clarke wrote:
> +package() {> + cd "$_builddir"> + install -Dm644 LICENSE.TXT "$pkgdir"/usr/share/licenses/$pkgname/LICENSE.TXT> + make DESTDIR="${pkgdir}" install || return 1 > +}
Again this contains whitespaces and the indention seems to be wrong.
Sören.
---
Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org
Help: alpine-aports+help@lists.alpinelinux.org
---
Re: [alpine-aports] [PATCH 2/6] testing/py-affine: new aport
I'll look into these changes over the weekend.
On Fri, Mar 18, 2016 at 5:50 AM, Timo Teras <timo.teras@iki.fi> wrote:
> On Sun, 28 Feb 2016 20:54:49 -0500> "Trevor R.H. Clarke" <trevor@notcows.com> wrote:>> > https://github.com/sgillies/affine> > Matrices describing affine transformation of the plane.> > ---> > testing/py-affine/APKBUILD | 36 ++++++++++++++++++++++++++++++++++++> > 1 file changed, 36 insertions(+)> > create mode 100644 testing/py-affine/APKBUILD> >> > diff --git a/testing/py-affine/APKBUILD b/testing/py-affine/APKBUILD> > new file mode 100644> > index 0000000..14969ba> > --- /dev/null> > +++ b/testing/py-affine/APKBUILD> > @@ -0,0 +1,36 @@> > +# Contributor: Trevor R.H. Clarke <trevor@notcows.com>> > +# Maintainer: Trevor R.H. Clarke <trevor@notcows.com>> > +pkgname=py-affine> > +pkgver="1.2.0"> > +pkgrel=0> > +pkgdesc="Matrices describing affine transformation of the plane."> > +url="https://github.com/sgillies/affine">> > +build() {> > + cd "$_builddir"> > + pip install affine --no-deps --root "$_builddir"> > +}>> Pip is used to download the package and will likely not match the one> listed as pkgver. Please use the real versioned download path so the> build reproducably gives the correct version.>> The same applies for patches 3-6. I did apply the first patch along> with the fixup commit flattened to it.>> We should probably add some helper to create APKBUILD for pip packages> similar to perl cpan and ruby.>
Re: [alpine-aports] [PATCH 2/6] testing/py-affine: new aport
On Sun, 28 Feb 2016 20:54:49 -0500
"Trevor R.H. Clarke" <trevor@notcows.com> wrote:
> https://github.com/sgillies/affine> Matrices describing affine transformation of the plane.> ---> testing/py-affine/APKBUILD | 36 ++++++++++++++++++++++++++++++++++++> 1 file changed, 36 insertions(+)> create mode 100644 testing/py-affine/APKBUILD> > diff --git a/testing/py-affine/APKBUILD b/testing/py-affine/APKBUILD> new file mode 100644> index 0000000..14969ba> --- /dev/null> +++ b/testing/py-affine/APKBUILD> @@ -0,0 +1,36 @@> +# Contributor: Trevor R.H. Clarke <trevor@notcows.com>> +# Maintainer: Trevor R.H. Clarke <trevor@notcows.com>> +pkgname=py-affine> +pkgver="1.2.0"> +pkgrel=0> +pkgdesc="Matrices describing affine transformation of the plane."> +url="https://github.com/sgillies/affine"> +build() {> + cd "$_builddir"> + pip install affine --no-deps --root "$_builddir"> +}
Pip is used to download the package and will likely not match the one
listed as pkgver. Please use the real versioned download path so the
build reproducably gives the correct version.
The same applies for patches 3-6. I did apply the first patch along
with the fixup commit flattened to it.
We should probably add some helper to create APKBUILD for pip packages
similar to perl cpan and ruby.
---
Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org
Help: alpine-aports+help@lists.alpinelinux.org
---