Hi,
please see some comments below.
On Wed, May 2, 2018 at 4:52 PM, Marian Buschsieweke <
marian.buschsieweke@ovgu.de> wrote:
> pygal is a dynamic SVG charting library written in python> https://pygal.org> ---> testing/pygal/APKBUILD | 42 ++++++++++++++++++++++++++++++++++++++++++> 1 file changed, 42 insertions(+)> create mode 100644 testing/pygal/APKBUILD>> diff --git a/testing/pygal/APKBUILD b/testing/pygal/APKBUILD> new file mode 100644> index 0000000000..e459f22ec6> --- /dev/null> +++ b/testing/pygal/APKBUILD> @@ -0,0 +1,42 @@> +# Maintainer: Marian Buschsieweke <marian.buschsieweke@ovgu.de>> +pkgname=pygal>
I think we should call it "py-gal" regardless of the actual upstream name,
for the sake of naming consistency of all pyhon packages.
> +pkgver=2.4.0> +pkgrel=0> +pkgdesc="pygal is a dynamic SVG charting library written in python"> +url="https://pygal.org"> +arch="noarch"> +license="LGPL3"> +makedepends="python2-dev python3-dev py-setuptools"> +subpackages="py2-${pkgname}:_py2 py3-${pkgname}:_py3"> +source="https://files.pythonhosted.org/packages/source/${pkgname:0:1}/$> pkgname/$pkgname-$pkgver.tar.gz"> +builddir="$srcdir"/$pkgname-$pkgver> +> +build() {> + cd "$builddir"> + python2 setup.py build || return 1> + python3 setup.py build || return 1> +}> +>
"|| return 1" can be omitted
Thanks!
/eo
Hi,
applied with further modifications.
On Wed, May 30, 2018 at 4:34 PM Marian Buschsieweke <
marian.buschsieweke@ovgu.de> wrote:
> Hi,>> thanks for the feedback. I attached the fixed patch.>> Kind regards,> Marian>> -------------------------------------------------------------> M.Sc. Marian Buschsieweke> Dept. Communication and Networked Systems (ComSys)> Institute for Intelligent Cooperating Systems (IKS)> Otto-von-Guericke-University of Magdeburg> Universitätsplatz 2, Building 29, Room 314> 39106 Magdeburg> Germany>> http://www.comsys.ovgu.de/Team/Marian+Buschsieweke.html> Tel.: +49 - 391 - 67 - 52673> Fax: +49 - 391 - 67 - 41161>> ------------------------------------------------------------->> On Wed, 30 May 2018 15:35:04 +0200> Leonardo Arena <rnalrd@gmail.com> wrote:>> > Hi,> >> > please see some comments below.> >> > On Wed, May 2, 2018 at 4:52 PM, Marian Buschsieweke <> > marian.buschsieweke@ovgu.de> wrote:> >> > > pygal is a dynamic SVG charting library written in python> > > https://pygal.org> > > ---> > > testing/pygal/APKBUILD | 42 ++++++++++++++++++++++++++++++++++++++++++> > > 1 file changed, 42 insertions(+)> > > create mode 100644 testing/pygal/APKBUILD>
Looking at other packages whose name start with "py", I kept the "py" in
the name and added the prefix "py-".
So the package name is actually py-pygal.
> > >> > > diff --git a/testing/pygal/APKBUILD b/testing/pygal/APKBUILD> > > new file mode 100644> > > index 0000000000..e459f22ec6> > > --- /dev/null> > > +++ b/testing/pygal/APKBUILD> > > @@ -0,0 +1,42 @@> > > +# Maintainer: Marian Buschsieweke <marian.buschsieweke@ovgu.de>> > > +pkgname=pygal> > >> >> >> > I think we should call it "py-gal" regardless of the actual upstream> name,> > for the sake of naming consistency of all pyhon packages.> >> >> >> > > +pkgver=2.4.0> > > +pkgrel=0> > > +pkgdesc="pygal is a dynamic SVG charting library written in python"> > > +url="https://pygal.org"> > > +arch="noarch"> > > +license="LGPL3">
Fixed license ID.
> > > +makedepends="python2-dev python3-dev py-setuptools"> > > +subpackages="py2-${pkgname}:_py2 py3-${pkgname}:_py3"> > > +source="> https://files.pythonhosted.org/packages/source/${pkgname:0:1}/$> > > pkgname/$pkgname-$pkgver.tar.gz"> > > +builddir="$srcdir"/$pkgname-$pkgver>
Disabled tests since there aren't any.
Thanks
/eo