Mail archive
alpine-aports

Re: [alpine-aports] [PATCH] testing/minidyndns: new aport

From: Leonardo Arena <rnalrd_at_gmail.com>
Date: Wed, 2 Jan 2019 16:13:32 +0100

Hi,

sorry for the late reply.

On Mon, Dec 31, 2018 at 3:49 PM Martin Rusko <martin.rusko_at_gmail.com> wrote:

> Many thanks for your comments. I will update it accordingly. I will
> send it again as new patch. There is just one thing I'm not certain
> about, see below.
>
> On Mon, Dec 31, 2018 at 12:18 PM Leonardo Arena <rnalrd_at_gmail.com> wrote:
> >>
> >> diff --git a/testing/minidyndns/minidyndns.confd
> b/testing/minidyndns/minidyndns.confd
> >> new file mode 100644
> >> index 0000000000..3cf5d10be2
> >> --- /dev/null
> >> +++ b/testing/minidyndns/minidyndns.confd
> >> _at__at_ -0,0 +1,5 @@
> >> +#
> >> +# Specify daemon options here.
> >> +#
> >> +
> >> +minidyndns_opts="--config /etc/minidyndns_config.yml --db
> /var/lib/minidyndns/db.yml"
> >
> >
> >
> > Since these are default values, may be you can add those to the init
> script itself and leave the conf file for customizations.
> >
> > : ${minidyndns_opts:="--config /etc/minidyndns_config.yml --db
> /var/lib/minidyndns/db.yml"}
> >
> Will I not stand in a way of someone who will want to change the
> location of these files? The administrator will need to edit both the
> file in conf.d and the one init.d script as well. I feel it's better
> to keep these options defined in conf.d file. If I'm overthinking it,
> just say so and I will move them to init.d script.
>
>
My suggestion above does hardcode the location of the configuration files.
If $minidyndns_opts is not set in conf.d/minidyndns, it sets the values to
those specified into init.d/minidyndns_opts.
The administrator does not need to touch the init.d at all to move the
configuration files somewhere else.

Thanks!

/eo



---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Wed Jan 02 2019 - 16:13:32 UTC