Mail archive
alpine-aports

Re: [alpine-aports] [PATCH] community/libcoro: fix build on armv7

From: Milan P. Stanic <mps_at_arvanta.net>
Date: Fri, 4 Jan 2019 11:43:47 +0100

On Fri, 2019-01-04 at 08:24, Timo Teras wrote:
> Hi,
>
> We also have now main/libucontext for the makecontext() support. Would
> it make sense to use CORO_UCONTEXT + libucontext; or is the CORO_SJLJ
> more favorable?

With -DCORO_UCONTEXT it doesn't build test.c
This test.c is taken from some github repo and is not in the upstream
CVS and to me seems as not needed in Alpine.

Without this file libcoro APKBUILD work just fine without needs for any
patch. I changed CFLAGS only to pass 'abuild check'.
If the test must be done there is conftest.c which could be tried
instead of the test.c

BTW, only one package, testing/tarantool, depends on libcoro.
Maybe libcoro could be moved to testing?
And, there is a newer version of libcoro on upstream site, but not sure
if it needs update in Alpine repo.

> Timo
>
> On Thu, 3 Jan 2019 19:06:36 +0100
> Milan P. Stanić <mps_at_arvanta.net> wrote:
>
> > use CORO_SJLJ build C flag on all architectures
> > ---
> > community/libcoro/APKBUILD | 8 ++------
> > 1 file changed, 2 insertions(+), 6 deletions(-)
> >
> > diff --git a/community/libcoro/APKBUILD b/community/libcoro/APKBUILD
> > index cdd5562aa7..0e0bd4307b 100644
> > --- a/community/libcoro/APKBUILD
> > +++ b/community/libcoro/APKBUILD
> > _at_@ -2,7 +2,7 @@
> > # Maintainer: Jakub Jirutka <jakub_at_jirutka.cz>
> > pkgname=libcoro
> > pkgver=6.513
> > -pkgrel=0
> > +pkgrel=1
> > pkgdesc="Coroutines (cooperative multitasking) in a portable fashion
> > implemented in C" url="http://software.schmorp.de/pkg/libcoro.html"
> > arch="all"
> > _at_@ -42,11 +42,7 @@ prepare() {
> > build() {
> > cd "$builddir"
> >
> > - CFLAGS="-fPIC -pedantic -Wall"
> > - case "$CARCH" in
> > - x86* | armv7*) CFLAGS="$CFLAGS -DCORO_ASM";;
> > - *) CFLAGS="$CFLAGS -DCORO_SJLJ";;
> > - esac
> > + CFLAGS="-DCORO_SJLJ -fPIC -pedantic -Wall"
> >
> > # Build shared lib.
> > $CC $CFLAGS -O3 -c coro.c
>
>
>
> ---
> Unsubscribe: alpine-aports+unsubscribe_at_lists.alpinelinux.org
> Help: alpine-aports+help_at_lists.alpinelinux.org
> ---
>


---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Fri Jan 04 2019 - 11:43:47 UTC