~alpine/aports

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
2 2

[alpine-aports] [PATCH] main/mpt-status: fix debian.tar.gz version

Milan P. Stanić <mps@arvanta.net>
Details
Message ID
<20190506215424.12347-1-mps@arvanta.net>
Sender timestamp
1557179664
DKIM signature
missing
Download raw message
Patch: +2 -2
---
 main/mpt-status/APKBUILD | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/main/mpt-status/APKBUILD b/main/mpt-status/APKBUILD
index b14cc26476..ea826529be 100644
--- a/main/mpt-status/APKBUILD
+++ b/main/mpt-status/APKBUILD
@@ -14,7 +14,7 @@ subpackages="$pkgname-doc"

# XXX: main site seems to be down right now; we shadow the Debian patch anyway
source="http://ftp.de.debian.org/debian/pool/main/m/mpt-status/mpt-status_${pkgver}.orig.tar.gz
	http://ftp.de.debian.org/debian/pool/main/m/mpt-status/mpt-status_${pkgver}-7.debian.tar.gz"
	http://ftp.de.debian.org/debian/pool/main/m/mpt-status/mpt-status_${pkgver}-8.debian.tar.gz"

_builddir="${srcdir}/mpt-status-${pkgver}"
prepare() {
@@ -52,4 +52,4 @@ package() {
}

sha512sums="48d9ecb3d9b42f7731a048ba6147fc2edabbb3ac7936c3273fc613e661f54a66c9f240283a7b84040efd059539fb1c59172b74fad50781647f98644c3da25cac  mpt-status_1.2.0.orig.tar.gz
f2de35cb781bef730e28449b75f0aa2b0b7f953dfda0ebd9231ff8b7e3649db34a25daa151ae0655458de2e07b6cbadf1b7e5977c5ac7585fa491bd071e36e00  mpt-status_1.2.0-7.debian.tar.gz"
e6a840e180af2bf358f8ec7b915750f3e65d2c7c3a528a7ef7bd58ea33581b304da3d21a719d9233fd97650b4865a36070f3e60ac1874e4952676ab183060900  mpt-status_1.2.0-8.debian.tar.gz"
-- 
2.20.1



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---
Natanael Copa <ncopa@alpinelinux.org>
Details
Message ID
<20190507224320.1591487a@ncopa-desktop.copa.dup.pw>
In-Reply-To
<20190506215424.12347-1-mps@arvanta.net> (view parent)
Sender timestamp
1557261800
DKIM signature
missing
Download raw message
On Mon,  6 May 2019 23:54:24 +0200
Milan P. Stani* <mps@arvanta.net> wrote:

> ---
>  main/mpt-status/APKBUILD | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/main/mpt-status/APKBUILD b/main/mpt-status/APKBUILD
> index b14cc26476..ea826529be 100644
> --- a/main/mpt-status/APKBUILD
> +++ b/main/mpt-status/APKBUILD
> @@ -14,7 +14,7 @@ subpackages="$pkgname-doc"
>  
>  # XXX: main site seems to be down right now; we shadow the Debian patch anyway
>  source="http://ftp.de.debian.org/debian/pool/main/m/mpt-status/mpt-status_${pkgver}.orig.tar.gz
> -	http://ftp.de.debian.org/debian/pool/main/m/mpt-status/mpt-status_${pkgver}-7.debian.tar.gz"
> +	http://ftp.de.debian.org/debian/pool/main/m/mpt-status/mpt-status_${pkgver}-8.debian.tar.gz"
>  
>  _builddir="${srcdir}/mpt-status-${pkgver}"
>  prepare() {
> @@ -52,4 +52,4 @@ package() {
>  }
>  
>  sha512sums="48d9ecb3d9b42f7731a048ba6147fc2edabbb3ac7936c3273fc613e661f54a66c9f240283a7b84040efd059539fb1c59172b74fad50781647f98644c3da25cac  mpt-status_1.2.0.orig.tar.gz
> -f2de35cb781bef730e28449b75f0aa2b0b7f953dfda0ebd9231ff8b7e3649db34a25daa151ae0655458de2e07b6cbadf1b7e5977c5ac7585fa491bd071e36e00  mpt-status_1.2.0-7.debian.tar.gz"
> +e6a840e180af2bf358f8ec7b915750f3e65d2c7c3a528a7ef7bd58ea33581b304da3d21a719d9233fd97650b4865a36070f3e60ac1874e4952676ab183060900  mpt-status_1.2.0-8.debian.tar.gz"


It looks like the content of the tarball is different, (checksum is not
the same). Will the resulting binary be different too? We need to bump
pkgrel if the content of the built package is different, so we dont end
up with two different apk builds with same version number.

Thanks!

-nc


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---
Milan P. Stanić <mps@arvanta.net>
Details
Message ID
<20190507210152.GA7956@arya.arvanta.net>
In-Reply-To
<20190507224320.1591487a@ncopa-desktop.copa.dup.pw> (view parent)
Sender timestamp
1557262912
DKIM signature
missing
Download raw message
On Tue, 2019-05-07 at 22:43, Natanael Copa wrote:
> On Mon,  6 May 2019 23:54:24 +0200
> Milan P. Stani* <mps@arvanta.net> wrote:
> 
> > ---
> >  main/mpt-status/APKBUILD | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/main/mpt-status/APKBUILD b/main/mpt-status/APKBUILD
> > index b14cc26476..ea826529be 100644
> > --- a/main/mpt-status/APKBUILD
> > +++ b/main/mpt-status/APKBUILD
> > @@ -14,7 +14,7 @@ subpackages="$pkgname-doc"
> >  
> >  # XXX: main site seems to be down right now; we shadow the Debian patch anyway
> >  source="http://ftp.de.debian.org/debian/pool/main/m/mpt-status/mpt-status_${pkgver}.orig.tar.gz
> > -	http://ftp.de.debian.org/debian/pool/main/m/mpt-status/mpt-status_${pkgver}-7.debian.tar.gz"
> > +	http://ftp.de.debian.org/debian/pool/main/m/mpt-status/mpt-status_${pkgver}-8.debian.tar.gz"
> >  
> >  _builddir="${srcdir}/mpt-status-${pkgver}"
> >  prepare() {
> > @@ -52,4 +52,4 @@ package() {
> >  }
> >  
> >  sha512sums="48d9ecb3d9b42f7731a048ba6147fc2edabbb3ac7936c3273fc613e661f54a66c9f240283a7b84040efd059539fb1c59172b74fad50781647f98644c3da25cac  mpt-status_1.2.0.orig.tar.gz
> > -f2de35cb781bef730e28449b75f0aa2b0b7f953dfda0ebd9231ff8b7e3649db34a25daa151ae0655458de2e07b6cbadf1b7e5977c5ac7585fa491bd071e36e00  mpt-status_1.2.0-7.debian.tar.gz"
> > +e6a840e180af2bf358f8ec7b915750f3e65d2c7c3a528a7ef7bd58ea33581b304da3d21a719d9233fd97650b4865a36070f3e60ac1874e4952676ab183060900  mpt-status_1.2.0-8.debian.tar.gz"
> 
> 
> It looks like the content of the tarball is different, (checksum is not
> the same). Will the resulting binary be different too? We need to bump
> pkgrel if the content of the built package is different, so we dont end
> up with two different apk builds with same version number.

In prepare() it uses patches from mpt-status_1.2.0-8.debian.tar.gz and
applies them, so I presume that the binary probably will be different.
(can't compare for sure because there is no '1.2.0-7.debian.tar.gz' on
Debian site).

So, agree that the pkgrel be bumped and sorry I forgot to do that when
sending patch.

-- 
regards


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---
Reply to thread Export thread (mbox)