~alpine/devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
2 2

[alpine-devel] [PATCH] testing/perl-dbd-sqlite: new aport

Jeff Bilyk <jbilyk@gmail.com>
Details
Message ID
<1295759701-17319-1-git-send-email-jbilyk@gmail.com>
Sender timestamp
1295759701
DKIM signature
missing
Download raw message
Patch: +32 -0
new aport
---
 testing/perl-dbd-sqlite/APKBUILD |   32 ++++++++++++++++++++++++++++++++
 1 files changed, 32 insertions(+), 0 deletions(-)
 create mode 100644 testing/perl-dbd-sqlite/APKBUILD

diff --git a/testing/perl-dbd-sqlite/APKBUILD b/testing/perl-dbd-sqlite/APKBUILD
new file mode 100644
index 0000000..72f8ef4
--- /dev/null
+++ b/testing/perl-dbd-sqlite/APKBUILD
@@ -0,0 +1,32 @@
# Contributor: Jeff Bilyk <jbilyk at gmail> 
# Maintainer: Natanael Copa <ncopa@alpinelinux.org>
pkgname=perl-dbd-sqlite
_realpkgname=DBD-SQLite
pkgver=0.31
pkgrel=0
pkgdesc="Perl CPAN DBD::SQLite module"
url="http://search.cpan.org/dist/${_realpkgname}"
arch="all"
license="GPL PerlArtistic"
depends="perl-dbi"
makedepends="perl perl-dev"
source="http://search.cpan.org/CPAN/authors/id/M/MS/MSERGEANT/${_realpkgname}-$pkgver.tar.gz"

_builddir="$srcdir"/${_realpkgname}-$pkgver

prepare() {
	return 0
}

build() {
	cd "$_builddir"
	perl Makefile.PL INSTALLDIRS=vendor
	make || return 1
}

package() {
	cd "$_builddir"
	make DESTDIR="$pkgdir" install
}

md5sums="4aa99c39104b7cd39129aec548e7d3e4  DBD-SQLite-0.31.tar.gz"
-- 
1.7.3.5



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---
Timo Teräs <timo.teras@iki.fi>
Details
Message ID
<4D3D18D1.2020000@iki.fi>
In-Reply-To
<1295759701-17319-1-git-send-email-jbilyk@gmail.com> (view parent)
Sender timestamp
1295849681
DKIM signature
missing
Download raw message
On 01/23/2011 07:15 AM, Jeff Bilyk wrote:
> new aport

Applied. Thanks.


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---
Leonardo Arena <rnalrd@gmail.com>
Details
Message ID
<AANLkTikmXCXASzHqWLDYtNW92_6Bhz0AHq3siE1r6bk8@mail.gmail.com>
In-Reply-To
<1295759701-17319-1-git-send-email-jbilyk@gmail.com> (view parent)
Sender timestamp
1295854515
DKIM signature
missing
Download raw message
On Sun, Jan 23, 2011 at 6:15 AM, Jeff Bilyk <jbilyk@gmail.com> wrote:
> new aport
> ---
>  testing/perl-dbd-sqlite/APKBUILD |   32 ++++++++++++++++++++++++++++++++
>  1 files changed, 32 insertions(+), 0 deletions(-)
>  create mode 100644 testing/perl-dbd-sqlite/APKBUILD
>
> diff --git a/testing/perl-dbd-sqlite/APKBUILD b/testing/perl-dbd-sqlite/APKBUILD
> new file mode 100644
> index 0000000..72f8ef4
> --- /dev/null
> +++ b/testing/perl-dbd-sqlite/APKBUILD
> @@ -0,0 +1,32 @@
> +# Contributor: Jeff Bilyk <jbilyk at gmail>
> +# Maintainer: Natanael Copa <ncopa@alpinelinux.org>
> +pkgname=perl-dbd-sqlite
> +_realpkgname=DBD-SQLite
> +pkgver=0.31
> +pkgrel=0
> +pkgdesc="Perl CPAN DBD::SQLite module"
> +url="http://search.cpan.org/dist/${_realpkgname}"
> +arch="all"
> +license="GPL PerlArtistic"
> +depends="perl-dbi"
> +makedepends="perl perl-dev"
> +source="http://search.cpan.org/CPAN/authors/id/M/MS/MSERGEANT/${_realpkgname}-$pkgver.tar.gz"
> +
> +_builddir="$srcdir"/${_realpkgname}-$pkgver
> +
> +prepare() {
> +       return 0
> +}
> +
> +build() {
> +       cd "$_builddir"
> +       perl Makefile.PL INSTALLDIRS=vendor

It would be better to set variable PERL_MM_USE_DEFAULT to 1, so that
ExtUtils::MakeMaker should not ask any question. It would be better to
add a "|| return 1" at the end.

> +       make || return 1
> +}
> +
> +package() {
> +       cd "$_builddir"
> +       make DESTDIR="$pkgdir" install

"Make" should have a "|| return 1".
After installing, you should search for perlocal.pod file and delete
it. It creates file collisions among perl packages.

# creates file collision among perl modules
find "$pkgdir" -name perllocal.pod -delete

> +}
> +
> +md5sums="4aa99c39104b7cd39129aec548e7d3e4  DBD-SQLite-0.31.tar.gz"
> --
> 1.7.3.5

I've applied those fixes, and took maintainership.

Thanks!

- leo


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---
Reply to thread Export thread (mbox)