~alpine/devel

3 2

[alpine-devel] main/gcc: fix Ada -fno-stack-check handling

Leslie P. Polzer | PORT ZERO <polzer@port-zero.com>
Details
Message ID
<5290AD0F.2010203@port-zero.com>
Sender timestamp
1385213199
DKIM signature
missing
Download raw message
Hi,

the old hack for this was probably too hacky; at least it
no longer worked for me when cross-compiling to armhf-musl.
Attached changeset replaces it with a cleaner approach that
works.

Cheers,

  Leslie

-- 
Dipl.Ing.(BA) Leslie P. Polzer | CTO - PORT ZERO
UG (haftungsbeschränkt)
Softwareentwicklung & IT Engineering
Adalbertstraße 7/8
10999 Berlin
Tel.: +49 (0)30 - 69 200 907 - 0
Fax: +49 (0)30 - 69 200 907 - 9
http://www.port-zero.com
Timo Teras <timo.teras@iki.fi>
Details
Message ID
<20131123180735.6b700fdf@vostro>
In-Reply-To
<5290AD0F.2010203@port-zero.com> (view parent)
Sender timestamp
1385222855
DKIM signature
missing
Download raw message
On Sat, 23 Nov 2013 14:26:39 +0100
"Leslie P. Polzer | PORT ZERO" <polzer@port-zero.com> wrote:

> the old hack for this was probably too hacky; at least it
> no longer worked for me when cross-compiling to armhf-musl.
> Attached changeset replaces it with a cleaner approach that
> works.

>  main/gcc/APKBUILD | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> @@ -228,10 +228,7 @@ prepare() {
>  	# fix ada bootstrap
>  	# piepatches adds -fstack-check to spec which breaks ada
> bootstrap # TODO: upstream this to piepatches
> -	sed -i -e 's/stage1_cflags="$stage1_cflags
> -fno-stack-protector"/stage1_cflags="$stage1_cflags
> -fno-stack-protector -fno-stack-check"/g' \
> -		configure
> -	sed -i -e 's/^ESP_NOSSP_CFLAGS =
> -fno-stack-protector$/ESP_NOSSP_CFLAGS = -fno-stack-protector
> -fno-stack-check/g' \
> -		Makefile.in
> +	export ADA_CFLAGS='-fno-stack-check'
>  
>  	# genautomata crashes with a "Bus Error" when compiled with
> PIC # mostly affecting cross-builds as on native build bootstrapping

If you set environment vars, it should be in build() or in the global
block. Setting those in prepare() only breaks "abuild build".

But if a full bootstrap works otherwise, this probably is a good idea.

Thanks,
 Timo


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---
Leslie P. Polzer | PORT ZERO <polzer@port-zero.com>
Details
Message ID
<52921C08.8080508@port-zero.com>
In-Reply-To
<20131123180735.6b700fdf@vostro> (view parent)
Sender timestamp
1385307144
DKIM signature
missing
Download raw message
On 11/23/2013 05:07 PM, Timo Teras wrote:

> If you set environment vars, it should be in build() or in the global
> block. Setting those in prepare() only breaks "abuild build".

Duh, thanks. Good we have peer review.

Modified patch attached.

  Leslie


-- 
Dipl.Ing.(BA) Leslie P. Polzer | CTO - PORT ZERO
UG (haftungsbeschränkt)
Softwareentwicklung & IT Engineering
Adalbertstraße 7/8
10999 Berlin
Tel.: +49 (0)30 - 69 200 907 - 0
Fax: +49 (0)30 - 69 200 907 - 9
http://www.port-zero.com
Timo Teras <timo.teras@iki.fi>
Details
Message ID
<20131129085056.57c5bbf3@vostro>
In-Reply-To
<52921C08.8080508@port-zero.com> (view parent)
Sender timestamp
1385707856
DKIM signature
missing
Download raw message
On Sun, 24 Nov 2013 16:32:24 +0100
"Leslie P. Polzer | PORT ZERO" <polzer@port-zero.com> wrote:

> On 11/23/2013 05:07 PM, Timo Teras wrote:
> 
> > If you set environment vars, it should be in build() or in the
> > global block. Setting those in prepare() only breaks "abuild build".
> 
> Duh, thanks. Good we have peer review.
> 
> Modified patch attached.

Applied. Thanks.


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---
Reply to thread Export thread (mbox)