~alpine/devel

1

[alpine-devel] initial commit of i3-wm apk

Details
Message ID
<20140515203158.GB6834@ctrlc.hu>
Sender timestamp
1400185918
DKIM signature
missing
Download raw message

Natanael Copa <ncopa@alpinelinux.org>
Details
Message ID
<20140519162536.0d0935c5@ncopa-desktop.alpinelinux.org>
In-Reply-To
<20140515203158.GB6834@ctrlc.hu> (view parent)
Sender timestamp
1400509536
DKIM signature
missing
Download raw message
On Thu, 15 May 2014 22:31:58 +0200
stef <l0ls0fo2i@ctrlc.hu> wrote:

> +@@ -136,6 +136,7 @@
> + LIBSN_LIBS   := $(call ldflags_for_lib, libstartup-notification-1.0,startup-notification-1)
> + 
> + # Pango
> ++PANGO_CFLAGS := $(call cflags_for_lib, pango)
> + PANGO_CFLAGS := $(call cflags_for_lib, cairo)
> + PANGO_CFLAGS += $(call cflags_for_lib, pangocairo)
> + I3_CPPFLAGS  += -DPANGO_SUPPORT=1

This looks wrong. it looks like it loses the cairo part. Shouldn't the
pango cflags be appended instead?

PANGO_CFLAGS := $(call cflags_for_lib, cairo)
PANGO_CFLAGS += $(call cflags_for_lib, pangocairo)
PANGO_CFLAGS += $(call cflags_for_lib, pango)


I applied anyways as is since it built.

Thanks!

-nc


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---
Reply to thread Export thread (mbox)