~alpine/devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
1

[alpine-devel] [PATCH] testing/libecap: new aport

Roger Newman <roger.newman@riseup.net>
Details
Message ID
<1412927481-3694-1-git-send-email-roger.newman@riseup.net>
Sender timestamp
1412927481
DKIM signature
missing
Download raw message
9 years ago
Patch: +45 -0 
http://e-cap.org/Home
eCAP allows an HTTP proxy or an ICAP server, to outsource content analysis and adaptation to a loadable module.
---
 testing/libecap/APKBUILD | 45 +++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)
 create mode 100644 testing/libecap/APKBUILD

diff --git a/testing/libecap/APKBUILD b/testing/libecap/APKBUILD
new file mode 100644
index 0000000..5fefe63
--- /dev/null
+++ b/testing/libecap/APKBUILD
@@ -0,0 +1,45 @@
# Maintainer: Roger Newman <roger.newman@riseup.net>
pkgname=libecap
pkgver=0.2.0
pkgrel=0
pkgdesc="eCAP libary to us with an HTTP proxy or an ICAP server, to outsource content analysis and adaptation to a loadable module."
url="http://www.e-cap.org/"
arch="all"
license="BSD"
depends=""
subpackages="$pkgname-dev"
source="http://www.measurement-factory.com/tmp/ecap/$pkgname-$pkgver.tar.gz"

_builddir="$srcdir"/$pkgname-$pkgver
prepare() {
	local i
	cd "$_builddir"
	for i in $source; do
		case $i in
		*.patch) msg $i; patch -p1 -i "$srcdir"/$i || return 1;;
		esac
	done
}

build() {
	cd "$_builddir"
	export CFLAGS="$CFLAGS -O2"
	CHOST="${CHOST}" ./configure \
		--prefix=/usr \
		--libdir=/lib \
		|| return 1
	make || return 1
}

package() {
	cd "$_builddir"
	make install \
		pkgconfigdir="/usr/lib/pkgconfig" \
		DESTDIR="$pkgdir" || return 1
        
	rm -f "$pkgdir"/lib/*.la
}

md5sums="e65a855f4fbb0f3136af7fe28249e883  libecap-0.2.0.tar.gz"
sha256sums="19e195d60cf67ec3b49fe4d109823d753546b5da115230499ad1a9cb65ca92d2  libecap-0.2.0.tar.gz"
sha512sums="5d39444ec79846b14a7f4292e51bb880befd2cbf581b257d5087517cfae1dce55e4439a90c08e0b8f5b3e8b2431dde8c6fab771c826489024f17625cfc8c777e  libecap-0.2.0.tar.gz"
-- 
2.0.0



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---
Natanael Copa <ncopa@alpinelinux.org>
Details
Message ID
<20141010135406.0507ec02@ncopa-desktop.alpinelinux.org>
In-Reply-To
<1412927481-3694-1-git-send-email-roger.newman@riseup.net> (view parent)
Sender timestamp
1412942046
DKIM signature
missing
Download raw message
9 years ago 
Hi,

please see comments inline below.

On Fri, 10 Oct 2014 09:51:21 +0200
Roger Newman <roger.newman@riseup.net> wrote:

> http://e-cap.org/Home
> eCAP allows an HTTP proxy or an ICAP server, to outsource content analysis and adaptation to a loadable module.
> ---
>  testing/libecap/APKBUILD | 45 +++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 45 insertions(+)
>  create mode 100644 testing/libecap/APKBUILD
> 
> diff --git a/testing/libecap/APKBUILD b/testing/libecap/APKBUILD
> new file mode 100644
> index 0000000..5fefe63
> --- /dev/null
> +++ b/testing/libecap/APKBUILD
> @@ -0,0 +1,45 @@
> +# Maintainer: Roger Newman <roger.newman@riseup.net>
> +pkgname=libecap
> +pkgver=0.2.0
> +pkgrel=0
> +pkgdesc="eCAP libary to us with an HTTP proxy or an ICAP server, to outsource content analysis and adaptation to a loadable module."
> +url="http://www.e-cap.org/"
> +arch="all"
> +license="BSD"
> +depends=""
> +subpackages="$pkgname-dev"
> +source="http://www.measurement-factory.com/tmp/ecap/$pkgname-$pkgver.tar.gz"
> +
> +_builddir="$srcdir"/$pkgname-$pkgver
> +prepare() {
> +	local i
> +	cd "$_builddir"
> +	for i in $source; do
> +		case $i in
> +		*.patch) msg $i; patch -p1 -i "$srcdir"/$i || return 1;;
> +		esac
> +	done
> +}
> +
> +build() {
> +	cd "$_builddir"
> +	export CFLAGS="$CFLAGS -O2"

why is -02 needed?

why is not -Os good enough?

> +	CHOST="${CHOST}" ./configure \

we normally do:

                --build=$CBUILD \
                --host=$CHOST \

> +		--prefix=/usr \
> +		--libdir=/lib \
> +		|| return 1
> +	make || return 1
> +}
> +
> +package() {
> +	cd "$_builddir"
> +	make install \
> +		pkgconfigdir="/usr/lib/pkgconfig" \
> +		DESTDIR="$pkgdir" || return 1
> +        
> +	rm -f "$pkgdir"/lib/*.la

why are files installed in /lib instead of /usr/lib?


I merged the 2 commits and fixed all the above issues.

Thanks!

-nc


> +}
> +
> +md5sums="e65a855f4fbb0f3136af7fe28249e883  libecap-0.2.0.tar.gz"
> +sha256sums="19e195d60cf67ec3b49fe4d109823d753546b5da115230499ad1a9cb65ca92d2  libecap-0.2.0.tar.gz"
> +sha512sums="5d39444ec79846b14a7f4292e51bb880befd2cbf581b257d5087517cfae1dce55e4439a90c08e0b8f5b3e8b2431dde8c6fab771c826489024f17625cfc8c777e  libecap-0.2.0.tar.gz"



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---
Reply to thread Export thread (mbox)